Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1967972: Add tokenreviews permissions for kube-proxy #1120

Merged
merged 1 commit into from Jun 7, 2021
Merged

[release-4.7] Bug 1967972: Add tokenreviews permissions for kube-proxy #1120

merged 1 commit into from Jun 7, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #960

/assign csrwng

@alexanderConstantinescu
Bug 1918375: Add tokenreviews permissions for kube-proxy
a680835 
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2021
Merged
@openshift-ci openshift-ci bot requested review from danwinship and dcbw June 4, 2021 15:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@openshift-cherrypick-robot: Bugzilla bug 1918375 has been cloned as Bugzilla bug 1967972. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1967972: Add tokenreviews permissions for kube-proxy

In response to this:

[release-4.7] Bug 1918375: Add tokenreviews permissions for kube-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1918375: Add tokenreviews permissions for kube-proxy [release-4.7] Bug 1967972: Add tokenreviews permissions for kube-proxy Jun 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1967972, which is invalid:

  • expected dependent Bugzilla bug 1918375 to target a release in 4.8.0, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1967972: Add tokenreviews permissions for kube-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 4, 2021
@csrwng
Copy link
Contributor

csrwng commented Jun 4, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@csrwng: This pull request references Bugzilla bug 1967972, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1918375 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1918375 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi June 4, 2021 15:23
@csrwng
Copy link
Contributor

csrwng commented Jun 4, 2021 •
edited

@alexanderConstantinescu ptal, the original bug fix only made it into 4.8, the fix is needed in 4.7 for IBM ROKS

alexanderConstantinescu
alexanderConstantinescu approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@alexanderConstantinescu alexanderConstantinescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2021
@danwinship
Copy link
Contributor

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@derekwaynecarr
Copy link
Member

(Patch-Manager) approve

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit f86cbb5 into openshift:release-4.7 Jun 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1967972 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1967972: Add tokenreviews permissions for kube-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu alexanderConstantinescu approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@dcbw dcbw Awaiting requested review from dcbw

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@csrwng csrwng

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @csrwng @danwinship @openshift-bot @derekwaynecarr @alexanderConstantinescu @openshift-merge-robot