Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1972587: config: Allow enable-profiling to be used to set profiling #1135

Merged
merged 1 commit into from Jun 24, 2021
Merged

[release-4.6] Bug 1972587: config: Allow enable-profiling to be used to set profiling #1135

merged 1 commit into from Jun 24, 2021

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 16, 2021

Cherry pick of #988 (#1129 was for 4.7 release)

@smarterclayton @creydr
config: Allow enable-profiling to be used to set profiling
9c1be32 
In addition, it defaults on because we expect debug/pprof to be
protected by the RBAC proxy. Allows a user to configure this post
deployment.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@creydr: This pull request references Bugzilla bug 1972587, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1972183 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1970497 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1972587: config: Allow enable-profiling to be used to set profiling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from abhat and dcbw June 16, 2021 09:51
@alexanderConstantinescu
Copy link
Contributor

/bugzilla refresh
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@alexanderConstantinescu: This pull request references Bugzilla bug 1972587, which is invalid:

  • expected dependent Bugzilla bug 1972183 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@creydr
Copy link
Member Author

creydr commented Jun 16, 2021

/retest

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@openshift-bot: This pull request references Bugzilla bug 1972587, which is invalid:

  • expected dependent Bugzilla bug 1972183 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member Author

creydr commented Jun 17, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@creydr: This pull request references Bugzilla bug 1972587, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1972183 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1972183 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 17, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi June 17, 2021 07:39
@creydr
Copy link
Member Author

creydr commented Jun 17, 2021

@abhat, @dcbw, @zhaozhanqi or @squeed could you please have a look at this PR?
Thanks

1 similar comment
@creydr
Copy link
Member Author

creydr commented Jun 22, 2021

@abhat, @dcbw, @zhaozhanqi or @squeed could you please have a look at this PR?
Thanks

@squeed
Copy link
Contributor

squeed commented Jun 22, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, creydr, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 23, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c111e84 into openshift:release-4.6 Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@creydr: All pull requests linked via external trackers have merged:

Bugzilla bug 1972587 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1972587: config: Allow enable-profiling to be used to set profiling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@dcbw dcbw Awaiting requested review from dcbw

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@creydr @alexanderConstantinescu @openshift-bot @squeed @bparees @openshift-merge-robot @smarterclayton