Bug 1989122: let openshift-sdn use EndpointSliceProxying #1166
Conversation
The "Validate that we don't allow the feature-gates to be set via user config" test was using a syntactically-invalid value of feature-gates, so it would have failed even if we did allow feature-gates to be set.
openshift-ci
bot
added
the
approved
It supports it now
|
CI is using pre-openshift/sdn#296 image still... |
|
/test e2e-gcp |
|
/test e2e-gcp |
|
/retest |
danwinship
force-pushed
the
endpointslices
branch
from
3b9093e
to
4d69ca6
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm woohoo |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danwinship
changed the title
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@danwinship: This pull request references Bugzilla bug 1989122, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-gcp-ovn PR only modifies unit tests and sdn config generation. OVN tests are irrelevant |
|
/test e2e-gcp |
|
@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-azure-ovn, ci/prow/e2e-gcp-ovn, ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec, ci/prow/e2e-openstack-ovn, ci/prow/e2e-vsphere-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
|
@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@danwinship: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1989122 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift/sdn#296 added support for
EndpointSliceProxyingto openshift-sdn, so we no longer have to forcibly disable it.Then once we rebase sdn to kube 1.22 we can use the endpoint termination stuff
/cc @abhat @Miciah