Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1989122: rebase to sdn-4.9-kubernetes-1.22.0-rc.0 #325

Merged
merged 2 commits into from Aug 4, 2021
Merged

Bug 1989122: rebase to sdn-4.9-kubernetes-1.22.0-rc.0 #325

merged 2 commits into from Aug 4, 2021

Conversation

danwinship
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@openshift-ci openshift-ci bot requested review from dcbw and squeed July 28, 2021 12:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@danwinship danwinship force-pushed the rebase-1.22.0-rc.0 branch 2 times, most recently from 69325b5 to de70c03 Compare July 29, 2021 12:42
@danwinship
Copy link
Contributor Author

blocked on openshift/cluster-network-operator#1166:

I0729 21:33:34.256269   18966 cmd.go:121] Reading proxy configuration from /config/kube-proxy-config.yaml
F0729 21:33:34.258059   18966 cmd.go:94] cannot set feature gate EndpointSliceProxying to false, feature is locked to true

@danwinship danwinship force-pushed the rebase-1.22.0-rc.0 branch 2 times, most recently from ad41c44 to 116a5f0 Compare August 2, 2021 02:07
@danwinship danwinship changed the title WIP rebase to sdn-4.9-kubernetes-1.22.0-rc.0 Bug 1989122: WIP rebase to sdn-4.9-kubernetes-1.22.0-rc.0 Aug 2, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2021

@danwinship: This pull request references Bugzilla bug 1989122, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

Bug 1989122: WIP rebase to sdn-4.9-kubernetes-1.22.0-rc.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi August 2, 2021 13:41
@danwinship danwinship changed the title Bug 1989122: WIP rebase to sdn-4.9-kubernetes-1.22.0-rc.0 Bug 1989122: rebase to sdn-4.9-kubernetes-1.22.0-rc.0 Aug 2, 2021
@squeed
Copy link
Contributor

squeed commented Aug 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor Author

/hold
tests won't pass until CNO#1166 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2021
@openshift-ci openshift-ci bot mentioned this pull request Aug 3, 2021
Merged
@danwinship
Copy link
Contributor Author

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@squeed
Copy link
Contributor

squeed commented Aug 4, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit e54a292 into openshift:master Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1989122 has been moved to the MODIFIED state.

In response to this:

Bug 1989122: rebase to sdn-4.9-kubernetes-1.22.0-rc.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the rebase-1.22.0-rc.0 branch August 5, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@squeed squeed Awaiting requested review from squeed

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@squeed squeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danwinship @squeed @openshift-bot