Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1988426: Change to use mountPath: /host #1170

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

mccv1r0
Copy link
Contributor

@mccv1r0 mccv1r0 commented Jul 30, 2021

Change iptables chain names to not conflict with existing workaround(s)

Signed-off-by: Michael Cambria mcambria@redhat.com
(cherry picked from commit 32d72e5)

Change iptables chain names to not conflict with existing workaround(s)

Signed-off-by: Michael Cambria <mcambria@redhat.com>
(cherry picked from commit 32d72e5)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Change to use mountPath: /host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and squeed July 30, 2021 13:35
@mccv1r0 mccv1r0 changed the title Change to use mountPath: /host Bug 1988426: Change to use mountPath: /host Jul 30, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: This pull request references Bugzilla bug 1988426, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 1984449 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1984449 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1988426: Change to use mountPath: /host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 30, 2021
@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/test e2e-vsphere-ovn

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: This pull request references Bugzilla bug 1988426, which is invalid:

  • expected dependent Bugzilla bug 1984449 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1988427 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1984449 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 1988427 to target a release in 4.8.0, 4.8.z, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/retest

2 similar comments
@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/retest

@Makdaam
Copy link
Member

Makdaam commented Aug 2, 2021

/retest

@squeed
Copy link
Contributor

squeed commented Aug 2, 2021

Do we need to do anything to clean up existing rules on the nodes? Remember, this will be applied unrelated to reboots.

@Makdaam
Copy link
Member

Makdaam commented Aug 5, 2021

/test e2e-vsphere-ovn

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Aug 10, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@mccv1r0: This pull request references Bugzilla bug 1988426, which is invalid:

  • expected dependent Bugzilla bug 1988425 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Aug 12, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@mccv1r0: This pull request references Bugzilla bug 1988426, which is invalid:

  • expected dependent Bugzilla bug 1988425 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sreber84
Copy link

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@sreber84: An error was encountered querying GitHub for users with public email (zzhao@redhat.com) for bug 1988426 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Aug 19, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@dcbw: This pull request references Bugzilla bug 1988426, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1988425 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1988425 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 19, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi August 19, 2021 01:32
@dcbw
Copy link
Contributor

dcbw commented Aug 19, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, mccv1r0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@deads2k deads2k added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 19, 2021
@deads2k
Copy link
Contributor

deads2k commented Aug 19, 2021

(patch manager)

urgent bz, 1.5

@dcbw
Copy link
Contributor

dcbw commented Aug 19, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9a9a870 into openshift:release-4.7 Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@mccv1r0: All pull requests linked via external trackers have merged:

Bugzilla bug 1988426 has been moved to the MODIFIED state.

In response to this:

Bug 1988426: Change to use mountPath: /host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants