New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2014021: Use proxy to connect to OSP cloud #1201

Merged

openshift-merge-robot merged 1 commit into openshift:release-4.9 from openshift-cherrypick-robot:cherry-pick-1173-to-release-4.9

Nov 3, 2021

openshift-cherrypick-robot commented Sep 24, 2021

This is an automated cherry-pick of #1173

/assign MaysaMacedo


          Allow to use proxy to connect to OSP cloud

b5cc6dd

When using Proxy and the installer is configured
on a restricted installation, Kuryr bootstrap
can't progress as the http client is not
configured to use Proxy. This commit ensures
proxy is used by relying on the cluster proxy
resource instead of relying on cvo to injecting
the proxy env vars.

openshift-ci bot assigned MaysaMacedo

openshift-cherrypick-robot mentioned this pull request

Bug 1985486: Use proxy to connect to OSP cloud #1173

Merged

Contributor

openshift-ci bot commented Sep 24, 2021

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 1985486 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


code 53: Bugzilla_api_key is not a valid parameter for the Bugzilla::Bug::create function.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 1985486: Use proxy to connect to OSP cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from alexanderConstantinescu and dulek

September 24, 2021 10:07

Contributor

MaysaMacedo commented Sep 24, 2021

/assign @danwinship

openshift-ci bot assigned danwinship

Contributor

MaysaMacedo commented Sep 24, 2021

/lgtm

openshift-ci bot added the lgtm label

Contributor

danwinship commented Sep 24, 2021

/approve

Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

16 similar comments

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Sep 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 11, 2021

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Contributor

openshift-ci bot commented Oct 11, 2021

@openshift-bot: This pull request references Bugzilla bug 1985486, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
expected Bugzilla bug 1985486 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-bot commented Oct 12, 2021

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Contributor

openshift-ci bot commented Oct 12, 2021

@openshift-bot: This pull request references Bugzilla bug 1985486, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
expected Bugzilla bug 1985486 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-bot commented Oct 13, 2021

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Contributor

openshift-ci bot commented Oct 13, 2021

@openshift-bot: This pull request references Bugzilla bug 1985486, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
expected Bugzilla bug 1985486 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-bot commented Oct 14, 2021

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Contributor

openshift-ci bot commented Oct 14, 2021

@openshift-bot: This pull request references Bugzilla bug 1985486, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
expected Bugzilla bug 1985486 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

MaysaMacedo commented Oct 14, 2021

/retitle [release-4.9] Bug 2014021: Use proxy to connect to OSP cloud

openshift-ci bot changed the title ~~[release-4.9] Bug 1985486: Use proxy to connect to OSP cloud~~ [release-4.9] Bug 2014021: Use proxy to connect to OSP cloud

Contributor

openshift-ci bot commented Oct 14, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014021, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2014021: Use proxy to connect to OSP cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-bot commented Oct 15, 2021

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Contributor

openshift-ci bot commented Oct 15, 2021

@openshift-bot: This pull request references Bugzilla bug 2014021, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member

sdodson commented Oct 15, 2021

/bugzilla refresh

openshift-ci bot added the bugzilla/valid-bug label

Contributor

openshift-ci bot commented Oct 15, 2021

@sdodson: This pull request references Bugzilla bug 2014021, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1985486 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1985486 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot removed the bugzilla/invalid-bug label

openshift-ci bot requested a review from eurijon

October 15, 2021 19:14

Contributor

MaysaMacedo commented Oct 18, 2021

/label backport-risk-assessed

Contributor

openshift-ci bot commented Oct 18, 2021

@MaysaMacedo: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stleerh commented Nov 1, 2021 •

edited

@MaysaMacedo Can you have someone add the "backport-risk-assessed" label since it failed to add this?

Contributor

alexanderConstantinescu commented Nov 2, 2021

/label backport-risk-assessed

openshift-ci bot added the backport-risk-assessed label

zhaozhanqi commented Nov 3, 2021

/label cherry-pick-approved

openshift-ci bot added the cherry-pick-approved label

openshift-merge-robot merged commit 2d3e8d6 into openshift:release-4.9

Contributor

openshift-ci bot commented Nov 3, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#1201

Bugzilla bug 2014021 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2014021: Use proxy to connect to OSP cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

MaysaMacedo commented Nov 3, 2021

/cherry-pick release-4.8

Author

openshift-cherrypick-robot commented Nov 3, 2021

@MaysaMacedo: #1201 failed to apply on top of branch "release-4.8":

Applying: Allow to use proxy to connect to OSP cloud
Using index info to reconstruct a base tree...
M	bindata/network/kuryr/003-config.yaml
M	bindata/network/kuryr/006-controller.yaml
M	go.mod
M	pkg/bootstrap/types.go
M	pkg/network/kuryr.go
M	pkg/platform/openstack/kuryr_bootstrap.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging pkg/platform/openstack/kuryr_bootstrap.go
Auto-merging pkg/network/kuryr.go
CONFLICT (content): Merge conflict in pkg/network/kuryr.go
Auto-merging pkg/bootstrap/types.go
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging bindata/network/kuryr/006-controller.yaml
Auto-merging bindata/network/kuryr/003-config.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow to use proxy to connect to OSP cloud
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MaysaMacedo mentioned this pull request

Bug 2022747: Allow to use proxy to connect to OSP cloud #1225

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved backport-risk-assessed bugzilla/severity-high bugzilla/valid-bug cherry-pick-approved lgtm