Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2039321: SDN: Expose controller metrics for collection #1250

Merged
merged 1 commit into from Jan 25, 2022
Merged

Bug 2039321: SDN: Expose controller metrics for collection #1250

merged 1 commit into from Jan 25, 2022

Conversation

martinkennelly
Copy link
Contributor

@martinkennelly martinkennelly commented Dec 13, 2021 •
edited

Signed-off-by: Martin Kennelly mkennell@redhat.com

/cc

Depends on: openshift/sdn#388

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: Martin Kennelly mkennell@redhat.com

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2021
@martinkennelly martinkennelly force-pushed the enable_sdn_metrics branch 2 times, most recently from 3ac2720 to a19c782 Compare December 14, 2021 10:02
@martinkennelly martinkennelly mentioned this pull request Dec 14, 2021
Merged
@martinkennelly martinkennelly force-pushed the enable_sdn_metrics branch 4 times, most recently from 204ab38 to b45c7de Compare December 14, 2021 17:16
@martinkennelly martinkennelly changed the title WIP: SDN: Expose controller metrics for collection SDN: Expose controller metrics for collection Dec 14, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@martinkennelly
Copy link
Contributor Author

verify test is broken due to a dependency repository getting nuked.

An issue I noticed with this PR is that only one of the SDN controller endpoints is active and exposes a HTTP endpoint. The inactive controller rbac proxy returns 504 bad gateway back to the caller. This isn't a problem but it would be nice not to waste this CPU time polling dead endpoints. If anyone has any ideas to improve this situation..

@martinkennelly
Copy link
Contributor Author

/cc @danwinship This PR is to expose SDN metrics from PR: openshift/sdn#358
Could you review since you have context?

@martinkennelly
Copy link
Contributor Author

rebased due to conflict

alexanderConstantinescu
alexanderConstantinescu approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@alexanderConstantinescu alexanderConstantinescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@martinkennelly
Copy link
Contributor Author

/retest-required

@martinkennelly martinkennelly changed the title SDN: Expose controller metrics for collection WIP: SDN: Expose controller metrics for collection Jan 5, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@martinkennelly martinkennelly mentioned this pull request Jan 11, 2022
Merged
@martinkennelly martinkennelly changed the title WIP: SDN: Expose controller metrics for collection Bug 2039321: SDN: Expose controller metrics for collection Jan 11, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@martinkennelly: An error was encountered querying GitHub for users with public email (zzhao@redhat.com) for bug 2039321 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2039321: SDN: Expose controller metrics for collection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@martinkennelly: An error was encountered querying GitHub for users with public email (zzhao@redhat.com) for bug 2039321 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2039321: SDN: Expose controller metrics for collection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@martinkennelly: This pull request references Bugzilla bug 2039321, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Bug 2039321: SDN: Expose controller metrics for collection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@martinkennelly: This pull request references Bugzilla bug 2039321, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Bug 2039321: SDN: Expose controller metrics for collection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkennelly
Copy link
Contributor Author

martinkennelly commented Jan 19, 2022 •
edited

Retesting after a merge of dependencies and associated test image should now be available.

@martinkennelly
Copy link
Contributor Author

Job e2e-agnostic-upgrade failed with a known issue: https://bugzilla.redhat.com/show_bug.cgi?id=1972948

@martinkennelly
Copy link
Contributor Author

/retest-required

@martinkennelly
SDN: Expose controller metrics for collection
ff56471 
This will expose egress IP/FW+rules metrics from SDN
controller.

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@danwinship
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, danwinship, martinkennelly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@martinkennelly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade ff56471 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-ovn ff56471 link false /test e2e-openstack-ovn
ci/prow/e2e-ovn-ipsec-step-registry ff56471 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn ff56471 link false /test e2e-vsphere-ovn
ci/prow/e2e-ovn-hybrid-step-registry ff56471 link false /test e2e-ovn-hybrid-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 83efd7f into openshift:master Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@martinkennelly: All pull requests linked via external trackers have merged:

Bugzilla bug 2039321 has been moved to the MODIFIED state.

In response to this:

Bug 2039321: SDN: Expose controller metrics for collection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricky-rav ricky-rav ricky-rav left review comments

@alexanderConstantinescu alexanderConstantinescu alexanderConstantinescu approved these changes

Assignees

@danwinship danwinship

@alexanderConstantinescu alexanderConstantinescu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@martinkennelly @danwinship @openshift-bot @ricky-rav @alexanderConstantinescu @openshift-merge-robot