Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

Merged
merged 5 commits into from
Feb 9, 2022
Merged

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

merged 5 commits into from
Feb 9, 2022

Commits on Dec 21, 2021

  1. whereabouts: add ip-reconciler cronjob 

    Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
    @maiqueb @dougbtv
    maiqueb authored and dougbtv committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    d4c098f View commit details
    Browse the repository at this point in the history

  2. ip-reconciler: update limits & set priority class 

    Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
    @maiqueb @dougbtv
    maiqueb authored and dougbtv committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7069bfd View commit details
    Browse the repository at this point in the history

  3. The ip-reconciler should not restart on failures. 

    When failures occur, a number of failed cronjobs pile up. Since another one will start in 5 minutes, we should just wait until the next instance in order to start another pod.

Additionally, we run only every 15 minutes and we cinch up the history limit for successful jobs.
    @dougbtv
    dougbtv committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    a455bb9 View commit details
    Browse the repository at this point in the history

  4. Whereabouts CRD should include a "podref" field. 

    This field is required for use in the IP reconciliation process for Whereabouts which uses the pod reference (podref) to calculate stranded IP addresses.
    @dougbtv
    dougbtv committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    99d4960 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. top-level validation should be used instead for whereabouts ippools CRD 

    Otherwise, we're throwing errors due to a change in formatting on openshift < 4.8

Additionally, the cronjob version was incorrect in openshift < 4.8 (needed v1beta1)
    @dougbtv
    dougbtv committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    ca3f045 View commit details
    Browse the repository at this point in the history