Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

dougbtv · 2021-12-22T17:13:55Z

This implements the Whereabouts IP reconciliation cron job

NOTE: This pull request should be merged AFTER openshift/whereabouts-cni#80

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>

When failures occur, a number of failed cronjobs pile up. Since another one will start in 5 minutes, we should just wait until the next instance in order to start another pod. Additionally, we run only every 15 minutes and we cinch up the history limit for successful jobs.

This field is required for use in the IP reconciliation process for Whereabouts which uses the pod reference (podref) to calculate stranded IP addresses.

openshift-ci · 2021-12-22T17:14:02Z

@dougbtv: This pull request references Bugzilla bug 2034358, which is invalid:

expected dependent Bugzilla bug 2034350 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034351 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034352 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2034355 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034350 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2034351 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2034352 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2021-12-22T17:18:26Z

/hold

openshift-bot · 2022-01-01T00:00:43Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2022-01-01T00:00:49Z

@openshift-bot: This pull request references Bugzilla bug 2034358, which is invalid:

expected dependent Bugzilla bug 2034350 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034351 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034352 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
expected dependent Bugzilla bug 2034355 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034350 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2034351 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2034352 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

squeed · 2022-01-18T11:22:44Z

/label backport-risk-assessed

squeed · 2022-01-18T11:23:24Z

/approve
/lgtm

Otherwise, we're throwing errors due to a change in formatting on openshift < 4.8 Additionally, the cronjob version was incorrect in openshift < 4.8 (needed v1beta1)

dougbtv · 2022-01-28T20:09:23Z

/bugzilla refresh

openshift-ci · 2022-01-28T20:09:29Z

@dougbtv: This pull request references Bugzilla bug 2034358, which is invalid:

expected dependent Bugzilla bug 2034355 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 2034350 to target a release in 4.7.0, 4.7.z, but it targets "4.10.0" instead
expected dependent Bugzilla bug 2034351 to target a release in 4.7.0, 4.7.z, but it targets "4.9.z" instead
expected dependent Bugzilla bug 2034352 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maiqueb · 2022-01-31T09:01:09Z

bindata/network/multus/multus.yaml

+    spec:
+      template:
+        spec:
+          backoffLimit: 0


The backoffLimit attribute - [0] - "specifies the number of retries
before marking this job failed. Defaults to 6."

The aforementioned attribute belongs to jobTemplate.spec, not to the
pod's spec template - [1].

[0] - https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#lifecycle
[1] - https://github.com/openshift/cluster-network-operator/pull/1290/files

tssurya · 2022-02-01T21:13:57Z

/lgtm

openshift-ci · 2022-02-01T21:14:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, squeed, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [squeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

weliang1 · 2022-02-03T16:28:50Z

/label qe-approved

weliang1 · 2022-02-03T16:28:59Z

/label cherry-pick-approved

dougbtv · 2022-02-03T16:33:53Z

/bugzilla refresh

openshift-ci · 2022-02-03T16:34:03Z

@dougbtv: This pull request references Bugzilla bug 2034358, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2034355 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2034355 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2022-02-09T16:04:06Z

/bugzilla refresh

dougbtv · 2022-02-09T16:05:09Z

/hold cancel

openshift-ci · 2022-02-09T16:05:13Z

@dougbtv: This pull request references Bugzilla bug 2034358, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2034355 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2034355 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2022-02-09T16:07:14Z

/retest-required

openshift-bot · 2022-02-09T17:19:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-02-09T17:53:20Z

@dougbtv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	`ca3f045`	link	false	`/test e2e-openstack-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dougbtv · 2022-02-09T18:16:07Z

/retest-required

openshift-bot · 2022-02-09T19:03:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-09T19:55:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-09T20:08:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-09T21:00:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-02-09T22:25:57Z

@dougbtv: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#1267

Bugzilla bug 2034358 has been moved to the MODIFIED state.

In response to this:

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maiqueb and others added 4 commits December 21, 2021 15:26

whereabouts: add ip-reconciler cronjob

d4c098f

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>

ip-reconciler: update limits & set priority class

7069bfd

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>

Whereabouts CRD should include a "podref" field.

99d4960

This field is required for use in the IP reconciliation process for Whereabouts which uses the pod reference (podref) to calculate stranded IP addresses.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 22, 2021

openshift-ci bot requested review from JacobTanenbaum and juanluisvaladas December 22, 2021 17:16

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 18, 2022

openshift-ci bot assigned squeed Jan 18, 2022

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2022

top-level validation should be used instead for whereabouts ippools CRD

ca3f045

Otherwise, we're throwing errors due to a change in formatting on openshift < 4.8 Additionally, the cronjob version was incorrect in openshift < 4.8 (needed v1beta1)

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022

maiqueb suggested changes Jan 31, 2022

View reviewed changes

openshift-ci bot assigned tssurya Feb 1, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 3, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 3, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 3, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022

openshift-merge-robot merged commit 7930c91 into openshift:release-4.6 Feb 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

dougbtv commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

dougbtv commented Dec 22, 2021

openshift-bot commented Jan 1, 2022

openshift-ci bot commented Jan 1, 2022

squeed commented Jan 18, 2022

squeed commented Jan 18, 2022

dougbtv commented Jan 28, 2022

openshift-ci bot commented Jan 28, 2022

maiqueb Jan 31, 2022 •

edited

tssurya commented Feb 1, 2022

openshift-ci bot commented Feb 1, 2022

weliang1 commented Feb 3, 2022

weliang1 commented Feb 3, 2022

dougbtv commented Feb 3, 2022

openshift-ci bot commented Feb 3, 2022

dougbtv commented Feb 9, 2022

dougbtv commented Feb 9, 2022

openshift-ci bot commented Feb 9, 2022

dougbtv commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-ci bot commented Feb 9, 2022 •

edited

dougbtv commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-ci bot commented Feb 9, 2022

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

Bug 2034358: Whereabouts IP Reconciliaton [backport 4.6] #1267

Conversation

dougbtv commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

dougbtv commented Dec 22, 2021

openshift-bot commented Jan 1, 2022

openshift-ci bot commented Jan 1, 2022

squeed commented Jan 18, 2022

squeed commented Jan 18, 2022

dougbtv commented Jan 28, 2022

openshift-ci bot commented Jan 28, 2022

maiqueb Jan 31, 2022 • edited

Choose a reason for hiding this comment

tssurya commented Feb 1, 2022

openshift-ci bot commented Feb 1, 2022

weliang1 commented Feb 3, 2022

weliang1 commented Feb 3, 2022

dougbtv commented Feb 3, 2022

openshift-ci bot commented Feb 3, 2022

dougbtv commented Feb 9, 2022

dougbtv commented Feb 9, 2022

openshift-ci bot commented Feb 9, 2022

dougbtv commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-ci bot commented Feb 9, 2022 • edited

dougbtv commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-bot commented Feb 9, 2022

openshift-ci bot commented Feb 9, 2022

maiqueb Jan 31, 2022 •

edited

openshift-ci bot commented Feb 9, 2022 •

edited