Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-3916: SDN alerts: Add $labels.node to SDNPodNotRady metric #1637

Merged
merged 1 commit into from
Dec 2, 2022
Merged

OCPBUGS-3916: SDN alerts: Add $labels.node to SDNPodNotRady metric #1637

merged 1 commit into from
Dec 2, 2022

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Nov 22, 2022 •
edited
Loading

kube_pod_status_ready metric has no label called node: https://github.com/kubernetes/kube-state-metrics/blob/master/docs/pod-metrics.md

Adding node name value from kube_pod_info metric, as it was done for kuryr in

Ref: https://issues.redhat.com/browse/OCPBUGS-3916

@zeeke zeeke changed the title SDN alerts: remove $labels.node OCPBUGS-3916: SDN alerts: remove $labels.node Nov 22, 2022
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 22, 2022
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-3916, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

kube_pod_status_ready metric has no label called node: https://github.com/kubernetes/kube-state-metrics/blob/master/docs/pod-metrics.md

Ref: https://issues.redhat.com/browse/OCPBUGS-3916
Signed-off-by: Andrea Panattoni apanatto@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke
Copy link
Contributor Author

zeeke commented Nov 22, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 22, 2022
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-3916, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke
SDN alerts: Add $labels.node to SDNPodNotRady
fade1e8 
`kube_pod_status_ready` metric has no label called `node`:
https://github.com/kubernetes/kube-state-metrics/blob/master/docs/pod-metrics.md

Adding node name value from `kube_pod_info` metric.

Ref: https://issues.redhat.com/browse/OCPBUGS-3916
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-3916, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

kube_pod_status_ready metric has no label called node: https://github.com/kubernetes/kube-state-metrics/blob/master/docs/pod-metrics.md

Adding node name value from kube_pod_info metric, as it was done for kuryr in

Ref: https://issues.redhat.com/browse/OCPBUGS-3916

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke zeeke changed the title OCPBUGS-3916: SDN alerts: remove $labels.node OCPBUGS-3916: SDN alerts: Add $labels.node to SDNPodNotRady metric Nov 23, 2022
@zeeke
Copy link
Contributor Author

zeeke commented Nov 23, 2022 •
edited
Loading

Tested by editing readinessProbe field of sdn DaemonSet:

oc patch daemonset \
    -n openshift-sdn sdn \
    --patch '{"spec":{ "template": {"spec":{"containers":[{"readinessProbe":{"exec":{"command":["bash", "-c", "[ `hostname` = ip-10-0-154-149] && sleep 3600 || echo ok"]}},"name":"sdn"}]}}}}'

Screenshot_20221123_151551

@zeeke
Copy link
Contributor Author

zeeke commented Nov 23, 2022

/retes-required

@zeeke
Copy link
Contributor Author

zeeke commented Nov 24, 2022

/retest-required

@martinkennelly
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@jcaamano
Copy link
Contributor

jcaamano commented Dec 2, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, martinkennelly, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022 •
edited
Loading

@zeeke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-network-mtu-migration-ovn-ipv4 fade1e8 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-ovn-hybrid-step-registry fade1e8 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-gcp-ovn-upgrade fade1e8 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-sdn fade1e8 link false /test e2e-openstack-sdn
ci/prow/e2e-network-mtu-migration-sdn-ipv4 fade1e8 link false /test e2e-network-mtu-migration-sdn-ipv4
ci/prow/e2e-hypershift-ovn fade1e8 link false /test e2e-hypershift-ovn
ci/prow/e2e-aws-ovn-serial fade1e8 link false /test e2e-aws-ovn-serial
ci/prow/e2e-azure-ovn fade1e8 link false /test e2e-azure-ovn
ci/prow/e2e-openstack-ovn fade1e8 link false /test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn fade1e8 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1101bdd and 2 for PR HEAD fade1e8 in total

@openshift-merge-robot openshift-merge-robot merged commit 051d328 into openshift:master Dec 2, 2022
@openshift-ci-robot
Copy link
Contributor

@zeeke: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3916 has been moved to the MODIFIED state.

In response to this:

kube_pod_status_ready metric has no label called node: https://github.com/kubernetes/kube-state-metrics/blob/master/docs/pod-metrics.md

Adding node name value from kube_pod_info metric, as it was done for kuryr in

Ref: https://issues.redhat.com/browse/OCPBUGS-3916

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@martinkennelly martinkennelly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeeke @openshift-ci-robot @martinkennelly @jcaamano @openshift-merge-robot