OCPBUGS-23199: add env var in whereabouts-reconciler daemonset #2160
Conversation
openshift-ci-robot
added
jira/severity-important
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-23199, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-23199, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @maiqueb |
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-23199, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
🤦♂️ I don't have approve powers on CNO. @dougbtv could you approve ? |
bindata/network/multus/multus.yaml
Outdated
| @@ -747,6 +747,8 @@ spec: | |||
| fieldRef: | |||
| apiVersion: v1 | |||
| fieldPath: spec.nodeName | |||
| - name: WHEREABOUTS_NAMESPACE | |||
| value: "openshift-multus" | |||
There was a problem hiding this comment.
Thank you! Can we also remove the above duplicated env section @ https://github.com/openshift/cluster-network-operator/blob/master/bindata/network/multus/multus.yaml#L729-L733 thanks
There was a problem hiding this comment.
wow, really good catch.
I guess this was overridding the env stanza ...
WHEREABOUTS_NAMESPACE env var was mistakenly added in a separate env section which doesn't take effect. WHEREABOUTS_NAMESPACE env var is used by whereabouts-reconciler to garbage collect the Pod IPs. When unset, it defaults to kube-system namespace, while ippool.whereabouts.cni.cncf.io custom resource only exist in openshift-multus namespace on openshift. Signed-off-by: Zenghui Shi <zshi@redhat.com>
zshi-redhat
force-pushed
the
OCPBUGS-23199
branch
from
436e03c
to
fcf831e
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, maiqueb, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@zshi-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 0d15e45
into
openshift:master
|
@zshi-redhat: Jira Issue OCPBUGS-23199: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23199 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.16.0-202312131052.p0.g0d15e45.assembly.stream for distgit cluster-network-operator. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-01-09-085011 |
|
/cherry-pick release-4.15 |
|
@zshi-redhat: new pull request created: #2242 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
WHEREABOUTS_NAMESPACE env var is used by whereabouts-reconciler to garbage collect the Pod IPs. When unset, it defaults to kube-system namespace, while ippool.whereabouts.cni.cncf.io custom resource only exist in openshift-multus namespace on openshift. Setting WHEREABOUTS_NAMESPACE env var will tell whereabouts-reconciler where to get the ippool customer resource