Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-28778: add env var in whereabouts-reconciler daemonset #2242

Merged
merged 1 commit into from Feb 6, 2024
Merged

[release-4.15] OCPBUGS-28778: add env var in whereabouts-reconciler daemonset #2242

merged 1 commit into from Feb 6, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2160

/assign zshi-redhat

@zshi-redhat
Remove extra env section in whereabouts-reconciler daemonset
869d5a5 
WHEREABOUTS_NAMESPACE env var was mistakenly added in a separate
env section which doesn't take effect.

WHEREABOUTS_NAMESPACE env var is used by whereabouts-reconciler
to garbage collect the Pod IPs. When unset, it defaults to
kube-system namespace, while ippool.whereabouts.cni.cncf.io
custom resource only exist in openshift-multus namespace on
openshift.

Signed-off-by: Zenghui Shi <zshi@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 1, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-23199 has been cloned as Jira Issue OCPBUGS-28778. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-28778: add env var in whereabouts-reconciler daemonset

In response to this:

This is an automated cherry-pick of #2160

/assign zshi-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-23199: add env var in whereabouts-reconciler daemonset [release-4.15] OCPBUGS-28778: add env var in whereabouts-reconciler daemonset Feb 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28778, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23199 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-23199 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2160

/assign zshi-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zshi-redhat
Copy link
Contributor

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 869d5a5 link false /test security
ci/prow/e2e-aws-ovn-serial 869d5a5 link false /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 869d5a5 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 869d5a5 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-single-node 869d5a5 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-vsphere-ovn-dualstack 869d5a5 link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dougbtv
Copy link
Member

dougbtv commented Feb 6, 2024

/lgtm

@dougbtv
Copy link
Member

dougbtv commented Feb 6, 2024

/approve

@dougbtv
Copy link
Member

dougbtv commented Feb 6, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weliang1
Copy link

weliang1 commented Feb 6, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3584d79 and 2 for PR HEAD 869d5a5 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 89a197f into openshift:release-4.15 Feb 6, 2024
36 of 42 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28778: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28778 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2160

/assign zshi-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.15.0-202402062238.p0.g89a197f.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-02-07-001709

@zshi-redhat
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@zshi-redhat: new pull request created: #2257

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@zshi-redhat zshi-redhat

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet