Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-25760: Keep the live migration annotation consistant with the enhancement doc #2179

Merged
merged 1 commit into from Jan 11, 2024
Merged

OCPBUGS-25760: Keep the live migration annotation consistant with the enhancement doc #2179

merged 1 commit into from Jan 11, 2024

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Dec 22, 2023

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 22, 2023
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Jira Issue OCPBUGS-25760, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://github.com/openshift/enhancements/blob/master/enhancements/network/sdn-live-migration.md#workflow-description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and tssurya December 22, 2023 03:41
@pliurh
Copy link
Contributor Author

pliurh commented Dec 22, 2023

/cc @kyrtapz @martinkennelly

@pliurh
Copy link
Contributor Author

pliurh commented Dec 22, 2023

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 22, 2023

/jira refresh
/lgtm

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 22, 2023
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-25760, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@pliurh
Copy link
Contributor Author

pliurh commented Dec 22, 2023

/retest

4 similar comments
@pliurh
Copy link
Contributor Author

pliurh commented Dec 26, 2023

/retest

@pliurh
Copy link
Contributor Author

pliurh commented Dec 26, 2023

/retest

@zshi-redhat
Copy link
Contributor

/retest

@pliurh
Copy link
Contributor Author

pliurh commented Jan 8, 2024

/retest

@jcaamano
Copy link
Contributor

jcaamano commented Jan 9, 2024

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@pliurh
Copy link
Contributor Author

pliurh commented Jan 9, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 873b329 and 2 for PR HEAD 52947af in total

@pliurh
Copy link
Contributor Author

pliurh commented Jan 10, 2024

/retest

@martinkennelly
Copy link
Contributor

/cc @martinkennelly

@martinkennelly martinkennelly mentioned this pull request Jan 10, 2024
Merged
@jcaamano
Copy link
Contributor

Seems that there is issues with hypershift CI
https://redhat-internal.slack.com/archives/GQ0CU2623/p1704723122748049

/override ci/prow/e2e-hypershift-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-hypershift-ovn

In response to this:

Seems that there is issues with hypershift CI
https://redhat-internal.slack.com/archives/GQ0CU2623/p1704723122748049

/override ci/prow/e2e-hypershift-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 975816e and 1 for PR HEAD 52947af in total

@pliurh
Copy link
Contributor Author

pliurh commented Jan 10, 2024

/retest

@martinkennelly
Copy link
Contributor

/test 4.16-upgrade-from-stable-4.15-images

@martinkennelly
Copy link
Contributor

/test e2e-hypershift-ovn

Job maybe passing again. See some passes recently.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@pliurh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 52947af link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4706ccf into openshift:master Jan 11, 2024
38 of 39 checks passed
@openshift-ci-robot
Copy link
Contributor

@pliurh: Jira Issue OCPBUGS-25760: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25760 has been moved to the MODIFIED state.

In response to this:

https://github.com/openshift/enhancements/blob/master/enhancements/network/sdn-live-migration.md#workflow-description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pliurh
Copy link
Contributor Author

pliurh commented Jan 11, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@pliurh: new pull request created: #2194

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@tssurya tssurya Awaiting requested review from tssurya

@kyrtapz kyrtapz Awaiting requested review from kyrtapz

@martinkennelly martinkennelly Awaiting requested review from martinkennelly

Assignees

@jcaamano jcaamano

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pliurh @openshift-ci-robot @kyrtapz @zshi-redhat @jcaamano @martinkennelly @openshift-cherrypick-robot