NP-877: Live migration suite e2e #28462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
f464a4b
to
1c7567d
Compare
|
Job Failure Risk Analysis for sha: 1c7567d
|
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
1c7567d
to
d11618c
Compare
|
Job Failure Risk Analysis for sha: d11618c
|
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
d11618c
to
f54dc19
Compare
|
Job Failure Risk Analysis for sha: f54dc19
|
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
2 times, most recently
from
e04d5ec
to
3f4533f
Compare
pliurh
reviewed
Dec 15, 2023
|
Job Failure Risk Analysis for sha: 3f4533f
|
martinkennelly
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
3f4533f
to
4d5a4b7
Compare
|
Job Failure Risk Analysis for sha: 4d5a4b7
|
|
|
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
4d5a4b7
to
409055e
Compare
|
|
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
dgoodwin
reviewed
Jan 10, 2024
neisw
reviewed
Jan 10, 2024
|
Shared another local sample output on slack: https://redhat-internal.slack.com/archives/CE4L0F143/p1704960360232179?thread_ts=1704459757.540179&cid=CE4L0F143 |
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
409055e
to
0352ca6
Compare
|
No functional changes - just I am happy with this PR now. |
|
@neisw Any more comments? |
|
Nope, I believe you have worked through Devan's last question. Will give him a chance to respond but I can tag it when you are ready if he doesn't get it. |
|
/lgtm release the hold when you are ready |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
/unhold If there are any additional comments, we can follow up with a patch. Hope thats ok Devon. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Bug created to improve monitors - they should not flake when a set of pods go from Running -> Pending: https://issues.redhat.com/browse/OCPBUGS-27059 |
Tests are disabled by default even if called in the 'all' suite because environment variable 'TEST_SDN_LIVE_MIGRATION_OPTIONS' must be set to a known value, otherwise tests are skipped. E.g. TEST_SDN_LIVE_MIGRATION_OPTIONS=target-cni=OVNKubernetes Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
martinkennelly
force-pushed
the
live-migration-suite-e2e
branch
from
34863ad
to
6500ca1
Compare
|
/lgtm All good here, thanks for looking into that test flake. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, martinkennelly, neisw, pliurh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit dcba6b5
into
openshift:master
19 of 23 checks passed
|
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.15 |
|
@martinkennelly: #28462 failed to apply on top of branch "release-4.15": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
martinkennelly
added a commit
to martinkennelly/release
that referenced
this pull request
Jan 19, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift/release
that referenced
this pull request
Jan 23, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
skordas
pushed a commit
to skordas/release
that referenced
this pull request
Jan 23, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
memodi
pushed a commit
to memodi/release
that referenced
this pull request
Mar 14, 2024
For details of the CNI migration feature see the feature enhancement PR [1]. Within o/origin, there is a suite for live migration. The suite accepts one environment variable. The value of this environment variable controls which CNI we are migrating to and optionally, if we want to trigger rollback. Rollback will only start once live migration to the target CNI is complete. If the environemnt variables value is blank, live migration test will be skipped. For more info, see the o/origin live migration PR [2]. Note: enabling of eip feature tests depends on fixing a bug [3]. A bug to track this enabling has also been created [4]. [1] openshift/enhancements#1064 [2] openshift/origin#28462 [3] https://issues.redhat.com/browse/OCPBUGS-26196 [4] https://issues.redhat.com/browse/NP-884 Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/hold
/cc
Add live migration suite and e2e test cases.
This can be executed by:
Prereq: ensure feature gate [1]
TechPreviewNoUpgradeis set before executing suite.[1] https://docs.openshift.com/container-platform/4.14/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-enabling-features-cli_nodes-cluster-enabling