Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30021: [release-4.14] Disable network-node-identity on ROKS #2286

Merged
merged 2 commits into from Mar 14, 2024
Merged

OCPBUGS-30021: [release-4.14] Disable network-node-identity on ROKS #2286

merged 2 commits into from Mar 14, 2024

Conversation

kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Feb 28, 2024 •
edited

Cherry-pick of #2278.
There were conflicts in the second commit.

@kyrtapz
Disable network-node-identity on ROKS
5cd95ee 
In environments with external control plane topology, the API server is deployed out of cluster.
This means that CNO cannot easily predict how to deploy and enforce the node identity webhook.
IBMCloud uses an external control plane topology with Calico as the CNI for both HyperShift based
ROKS deployments and IBM ROKS Toolkit based ROKS deployments. There is no signifficant value
added by the network-node-identity in this scenario.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit ad94f41)
(cherry picked from commit 8283f85)
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Feb 28, 2024

/jira cherry-pick OCPBUGS-29654

@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-29654 has been cloned as Jira Issue OCPBUGS-30021. Will retitle bug to link to clone.
/retitle OCPBUGS-30021: [release-4.14] Disable network-node-identity on ROKS

In response to this:

/jira cherry-pick OCPBUGS-29654

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] Disable network-node-identity on ROKS OCPBUGS-30021: [release-4.14] Disable network-node-identity on ROKS Feb 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-30021, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29654 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 28, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@rtheis
Copy link

rtheis commented Mar 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@rtheis: This pull request references Jira Issue OCPBUGS-30021, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29654 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rtheis
Copy link

rtheis commented Mar 8, 2024

/retest

@kyrtapz
getMultusAdmissionControllerReplicas for non-hypershift externalTopol…
b15f935 
…ogy clusters

a5edddf introduced a change that doesn't work on
non-hypershift clusters with external controllplane. Re-introduce the original
logic for this type of clusters.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 21a564c)
Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 4193961)
Signed-off-by: Patryk Diak <pdiak@redhat.com>
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Mar 8, 2024

/jira refresh
@dougbtv ptal

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 8, 2024
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-30021, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29654 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29654 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh
@dougbtv ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Mar 11, 2024

/retest

s1061123
s1061123 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rtheis
Copy link

rtheis commented Mar 14, 2024

/retest

@dougbtv
Copy link
Member

dougbtv commented Mar 14, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-kuryr b15f935 link false /test e2e-openstack-kuryr
ci/prow/security b15f935 link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 b15f935 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jechen0648
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5c074c9 into openshift:release-4.14 Mar 14, 2024
37 of 40 checks passed
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-30021: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30021 has been moved to the MODIFIED state.

In response to this:

Cherry-pick of #2278.
There were conflicts in the second commit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.14.0-202403141740.p0.g5c074c9.assembly.stream.el8 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 8, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-04-12-112012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 s1061123 approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@s1061123 s1061123

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet