Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30021: [release-4.14] Disable network-node-identity on ROKS #2286

Merged

Commits on Feb 28, 2024

  1. Disable network-node-identity on ROKS

    In environments with external control plane topology, the API server is deployed out of cluster.
    This means that CNO cannot easily predict how to deploy and enforce the node identity webhook.
    IBMCloud uses an external control plane topology with Calico as the CNI for both HyperShift based
    ROKS deployments and IBM ROKS Toolkit based ROKS deployments. There is no signifficant value
    added by the network-node-identity in this scenario.
    
    Signed-off-by: Patryk Diak <pdiak@redhat.com>
    (cherry picked from commit ad94f41)
    (cherry picked from commit 8283f85)
    kyrtapz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5cd95ee View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. getMultusAdmissionControllerReplicas for non-hypershift externalTopol…

    …ogy clusters
    
    a5edddf introduced a change that doesn't work on
    non-hypershift clusters with external controllplane. Re-introduce the original
    logic for this type of clusters.
    
    Signed-off-by: Patryk Diak <pdiak@redhat.com>
    (cherry picked from commit 21a564c)
    Signed-off-by: Patryk Diak <pdiak@redhat.com>
    (cherry picked from commit 4193961)
    Signed-off-by: Patryk Diak <pdiak@redhat.com>
    kyrtapz committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b15f935 View commit details
    Browse the repository at this point in the history