SDN-4596: Update (B)ANP CRDs; prepare for GA #2328
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tssurya: This pull request references SDN-4569 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tssurya
changed the title
|
@tssurya: This pull request references SDN-4596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tssurya: This pull request references SDN-4596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tssurya
force-pushed
the
update-ANP-CRDs-4.16-GA
branch
from
cb0cacd
to
c5b092e
Compare
|
@tssurya: This pull request references SDN-4596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test 4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade |
|
/tide refresh |
|
/retest-required |
|
/test e2e-gcp-ovn-upgrade |
|
/test e2e-aws-ovn-shared-to-local-gateway-mode-migration |
|
/test e2e-vsphere-ovn-dualstack-primaryv6 |
|
/retest |
|
/assign @kyrtapz |
|
Would it be possible to automate pulling in the CRDs from https://github.com/kubernetes-sigs/network-policy-api/tree/main/config/crd/standard? |
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
isCIDR() has been backported in OCP so we can use this versus in upstream k/k its expected to be available only form 1.31 Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
force-pushed
the
update-ANP-CRDs-4.16-GA
branch
from
c5b092e
to
aad3a39
Compare
|
@tssurya: This pull request references SDN-4596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yes but that is a larger change I think? meaning we have the same problem for syncing crds from ovnk upstream like efw, eip, apbr etc in cno which are done manually. We can have a tech debt cleanup? |
ovn-k upstream CRDs are not versioned so that would be tricky to achieve, it should be doable here if we use a proper version from the upstream repository. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-gcp-ovn |
|
/test e2e-gcp-ovn-upgrade |
|
/test e2e-gcp-ovn |
|
@tssurya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit a267ad2
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.16.0-202404050447.p0.ga267ad2.assembly.stream.el9 for distgit cluster-network-operator. |
This PR updates the ANP/BANP CRDs to reflect the latest changes, i.e egress support and this reflects the release v0.1.3 upstream: https://github.com/kubernetes-sigs/network-policy-api/releases/tag/v0.1.3 (had to change bundle version manually since release is not cut yet but this is just aesthetics) + adds support for
isCIDR()in the networks peer which is OCP carry only HACK because it hits k/k only in 1.31 release but we have support for this in OCP thanks to openshift/kubernetes#1828The manual changes are a second commit on top with OCPHACKs title, we should hopefully sync with upstream once we cut a release + we become 1.31 so that network-policy-api repo can also leverage isCIDR()
source-code: https://github.com/tssurya/network-policy-api/tree/final-ocp-crds-4.16-ga