OCPBUGS-26067: Backport CEL IP and CIDR validations #1828
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@JoelSpeed: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
JoelSpeed
force-pushed
the
backport-cel-ip-cidr
branch
from
5e7c9b9
to
14d8b28
Compare
|
/hold I've rebase this to make sure it's up to date with the 1.29 changes, will be ready for merge once #1815 merges and I've rebased again Will also be bringing up for discussion in the new year |
openshift-ci
bot
added
the
do-not-merge/hold
This adds new CEL functions to the library for validating if a string is an IP address, and, if it can be parsed as an IP address, adds additional accessors to get properties of the IP address.
This commit needs to be carried until we rebase onto Kube 1.31. We have backported the library changes to 1.28, which means they can then be used in 1.29. Upstream, they were only introduced in 1.30 which means they wouldn't be usable until 1.31. This allows us to improve our API validation from OpenShift 4.16 onwards, instead of OpenShift 4.18 onwards.
JoelSpeed
force-pushed
the
backport-cel-ip-cidr
branch
from
14d8b28
to
91f2420
Compare
|
@JoelSpeed: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/hold cancel The 1.29 rebase has merged and I've got this rebased, assuming tests pass I think this could be merged |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Unit failure looks unrelated |
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
added
the
backports/validated-commits
|
/test unit |
openshift-ci
bot
removed
the
backports/unvalidated-commits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
JoelSpeed
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-26067, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit e74ad97
into
openshift:master
|
@JoelSpeed: Jira Issue OCPBUGS-26067: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-26067 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202401051633.p0.ge74ad97.assembly.stream for distgit openshift-enterprise-pod. |
A recent addition upstream includes new CEL validations for IPs and CIDRs. We have a number of APIs in tech preview in 4.15 that intend to be promoted to GA in 4.16, that could benefit from these IP address validations.
Our current approach is to use regex which does not provide a good experience when an error occurs, the whole regex is spit out.
The intention here is to backport the library change, which can be dropped when rebasing to 1.30. And the also change the introduced version to 1.28 (which also means this needs backporting to 4.15), so that, we ship the library in 4.15, but only start using it in 4.16.
Upstream, they were only introduced in 1.30 which means they wouldn't be usable until 1.31.
This allows us to improve our API validation from OpenShift 4.16 onwards, instead of OpenShift 4.18 onwards.
Previously discussed with @deads2k
/assign @deads2k