OVNKubernetes: introduce OVS anti-selector #357
Conversation
openshift-ci-robot
added
the
size/L
|
Hi @mmirecki. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
openshift-ci-robot
requested review from
alexanderConstantinescu and
pecameron
|
@dcbw in case you have RHCOS8 masters and RHEL7 workers, where you want to use OVS SLB bonding for workload. I know, very specific. It is easy to install external OVS on RHEL, very hard to have it on RHCOS. |
|
/test e2e-aws-ovn-kubernetes |
|
@mmirecki: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/test e2e-aws-own-kubernetes |
|
/test e2e-aws-ovn-kubernetes |
1 similar comment
|
/test e2e-aws-ovn-kubernetes |
openshift-ci-robot
added
the
needs-rebase
OVNKubernetes is shipped with its own openvswitch service running as a separate daemonset. However, in some cases we may want to use an external openvswitch running on the host (e.g. to use it for host networking). In order to support a mixed environment where some hosts have this external service and some don't, we introduce an openvswitch anti-selector: network.operator.openshift.io/external-openvswitch Note that this selector has to be set before the operator is started. Otherwise, the label would not take effect on already scheduled pods.
openshift-ci-robot
removed
the
needs-rebase
|
/test e2e-aws-ovn-kubernetes |
|
/retest |
|
Documented in PR 375 |
|
@squeed similar patch landed for OpenShiftSDN, could we move this one through the finish line? |
|
The OpenShiftSDN equivalent PR 346 is merged. |
There was a problem hiding this comment.
@squeed Since we are moving ovs to host do we need this?
CC: @JacobTanenbaum @dcbw
|
@pecameron we'd appreciate if this got in, so we can start initial testing of OVN with external OVS before your patches land. |
|
Okay, now that 4.4 has cut, we can try and merge this. @JacobTanenbaum , can you review please? |
|
@danwinship @dcbw @JacobTanenbaum PTAL after rebase. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
Rebased, please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, mmirecki, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
OVNKubernetes is shipped with its own openvswitch service running
as a separate daemonset. However, in some cases we may want to use
an external openvswitch running on the host (e.g. to use it for
host networking). In order to support a mixed environment where some
hosts have this external service and some don't, we introduce an
openvswitch anti-selector:
network.operator.openshift.io/external-openvswitch
Note that this selector has to be set before the operator is started.
Otherwise, the label would not take effect on already scheduled
pods.
Related to:
#346