Skip to content

OpenShiftSDN: introduce OVS anti-selector - #346

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
phoracek:external_ovs_label
Nov 4, 2019
Merged

OpenShiftSDN: introduce OVS anti-selector#346
openshift-merge-robot merged 1 commit into
openshift:masterfrom
phoracek:external_ovs_label

Conversation

@phoracek

@phoracek phoracek commented Oct 10, 2019

Copy link
Copy Markdown
Member

OpenShiftSDN is shipped with its own openvswitch service running
as a separate daemonset. However, in some cases we may want to use
an external openvswitch running on the host (e.g. to use it for
host networking). In order to support a mixed environment where some
hosts have this external service and some don't, we introduce
openvswitch anti-selector:

network.operator.openshift.io/external-openvswitch

Note that this selector has to be set before the operator is started.
Otherwise, the label would not take effect on already scheduled
pods.

TODO: documentation

Signed-off-by: Petr Horacek phoracek@redhat.com

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2019
@squeed

squeed commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

TODO: consider doing the same for OVN, the issue there is that OVS is not a separate DS, but a container under OVN DS

If you file a corresponding PR for OVN, I'd merge it. Note that you'll have to adjust some bindmounts as well.

@mmirecki

Copy link
Copy Markdown

If you file a corresponding PR for OVN, I'd merge it. Note that you'll have to adjust some bindmounts as well.

PR for ovn: #357

@mmirecki

Copy link
Copy Markdown

Documented in PR 375

OpenShiftSDN is shipped with its own openvswitch service running
as a separate daemonset. However, in some cases we may want to use
an external openvswitch running on the host (e.g. to use it for
host networking). In order to support a mixed environment where some
hosts have this external service and some don't, we introduce
openvswitch anti-selector:

network.operator.openshift.io/external-openvswitch

Note that this selector has to be set *before* the operator is started.
Otherwise, the label would not take effect on already scheduled
pods.

Signed-off-by: Petr Horacek <phoracek@redhat.com>
@phoracek phoracek changed the title WIP: OpenShiftSDN: introduce OVS anti-selector OpenShiftSDN: introduce OVS anti-selector Oct 31, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2019
@phoracek

Copy link
Copy Markdown
Member Author

Thanks @mmirecki!

@squeed can we move this forward now?

@squeed

squeed commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@openshift-ci-robot

openshift-ci-robot commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

@phoracek: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 0c9b2a8 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
openshift-merge-robot merged commit ece98c0 into openshift:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants