Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovn-kubernetes: add basic control plane alerts #378

Merged
merged 1 commit into from
Nov 5, 2019
Merged

ovn-kubernetes: add basic control plane alerts #378

merged 1 commit into from
Nov 5, 2019

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Oct 31, 2019

Since there is a periodic process that commits to the northbound database (and is mirrored to the southbound), we have a good signal for an e2e test.

(note: this needs an upstream PR to merge, and for that to be pulled downstream)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@squeed
Copy link
Contributor Author

squeed commented Nov 1, 2019

/hold cancel
/test e2e-aws-ovn-kubernetes

@squeed squeed changed the title [wip] ovn-kubernetes: add basic control plane alerts ovn-kubernetes: add basic control plane alerts Nov 1, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2019
@squeed
Copy link
Contributor Author

squeed commented Nov 1, 2019

All PRs are merged. This is ready to be reviewed and merged.

@JacobTanenbaum
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@dcbw
Copy link
Contributor

dcbw commented Nov 1, 2019

/retest

Since there is a periodic process that commits to the northbound
database (and is mirrored to the southbound), we have a good signal for
an e2e test.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2019
@squeed
Copy link
Contributor Author

squeed commented Nov 2, 2019

rebased - no change
/test e2e-aws-ovn-kubernetes

@squeed
Copy link
Contributor Author

squeed commented Nov 4, 2019

test failure is a flake
/test e2e-aws-ovn-kubernetes

@squeed
Copy link
Contributor Author

squeed commented Nov 4, 2019

/test e2e-aws-ovn-kubernetes

@squeed
Copy link
Contributor Author

squeed commented Nov 4, 2019

It looks like one test failed because network traffic wasn't flowing.

Concerning.

@squeed
Copy link
Contributor Author

squeed commented Nov 4, 2019

Aha. That's a known flake right now. Whew.

@dcbw
Copy link
Contributor

dcbw commented Nov 5, 2019

/test e2e-aws-ovn-kubernetes

@dcbw
Copy link
Contributor

dcbw commented Nov 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, JacobTanenbaum, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2ce4567 into openshift:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants