-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1766066: Revert "Merge pull request #334 from danehans/bz_1758656" #388
Bug 1766066: Revert "Merge pull request #334 from danehans/bz_1758656" #388
Conversation
This reverts commit a858609, reversing changes made to 1eed813. We found in BZ https://bugzilla.redhat.com/show_bug.cgi?id=1762618 that at least some of our code, running on cluster, was accessing the external instead of internal api. While it is possible to make it work (by allowing your proxy to talk from internal to the apiserver) this is a change/regression from GA. Since we hit this with at least 1 part of our code we have decided to revert and try again with more testing.
@eparis: This pull request references Bugzilla bug 1762618, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eparis: This pull request references Bugzilla bug 1766066, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
manually overriding BZ check since this is a revert and the BZ in question is the long term fix... |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, eparis, pecameron, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bug 1770223: Reverts PR #388
This reverts commit a858609, reversing
changes made to 1eed813.
We found in BZ https://bugzilla.redhat.com/show_bug.cgi?id=1762618 that at least
some of our code, running on cluster, was accessing the external instead of internal
api.
While it is possible to make it work (by allowing your proxy to talk from internal
to the apiserver) this is a change/regression from GA. Since we hit this with at
least 1 part of our code we have decided to revert and try again with more testing.