Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1769015: Bump library go #398

Merged
merged 5 commits into from Dec 19, 2019
Merged

Bug 1769015: Bump library go #398

merged 5 commits into from Dec 19, 2019

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Nov 14, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 14, 2019
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1769015, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1769015: Bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 14, 2019
@abhat
Copy link
Contributor Author

abhat commented Nov 14, 2019

I will uncomment the crdTypes in https://github.com/openshift/origin/pull/24058/files#diff-b212b5fb9c78264b938f2bc554a80376R140 via a separate PR on origin.

@alexanderConstantinescu, @JacobTanenbaum - the egressnetworkpolicies, hostsubnets etc. are not CRDs right?

/cc @soltysh, @squeed PTAL.

@abhat
Copy link
Contributor Author

abhat commented Nov 15, 2019

/test e2e-gcp-upgrade

@abhat
Copy link
Contributor Author

abhat commented Nov 21, 2019

/test e2e-gcp

@abhat
Copy link
Contributor Author

abhat commented Nov 21, 2019

/test e2e-gcp-upgrade

@knobunc
Copy link
Contributor

knobunc commented Nov 26, 2019

/retest

@abhat
Copy link
Contributor Author

abhat commented Nov 26, 2019

/test e2e-gcp

@abhat
Copy link
Contributor Author

abhat commented Nov 26, 2019

/test e2e-gcp-upgrade

@abhat abhat mentioned this pull request Nov 26, 2019
Merged
@abhat
Copy link
Contributor Author

abhat commented Nov 27, 2019

/test e2e-gcp

@abhat
Copy link
Contributor Author

abhat commented Dec 9, 2019

/test e2e-gcp

@squeed
Copy link
Contributor

squeed commented Dec 9, 2019

So, are we using the generated CRDs from library-go or not? Did we have to customize them?

@abhat
Copy link
Contributor Author

abhat commented Dec 10, 2019 via email

@squeed
Copy link
Contributor

squeed commented Dec 10, 2019

ack
/approve
@danwinship can you give this a quick look-over and lgtm?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
danwinship
danwinship requested changes Dec 10, 2019
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
bindata/network/openshift-sdn/001-crd.yaml Outdated Show resolved Hide resolved
bindata/network/openshift-sdn/001-crd.yaml Outdated Show resolved Hide resolved
@abhat
Copy link
Contributor Author

abhat commented Dec 18, 2019 •
edited

@squeed, @danwinship can one of you lgtm please?

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, danwinship, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2cbee6c into openshift:master Dec 19, 2019
@abhat abhat mentioned this pull request Jan 7, 2020
Merged
@juanluisvaladas
Copy link
Contributor

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2020
Closed
@openshift-cherrypick-robot
Copy link

@juanluisvaladas: new pull request created: #491

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed left review comments

@danwinship danwinship danwinship requested changes

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@abhat @openshift-ci-robot @knobunc @squeed @danwinship @juanluisvaladas @openshift-cherrypick-robot @openshift-merge-robot