Bug 1782303: Bump library go

[openshift-cherrypick-robot]

This is an automated cherry-pick of #398

/assign juanluisvaladas

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1769015, which is invalid:

• expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
• expected Bugzilla bug 1769015 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1769015: Bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign dcbw
You can assign the PR to them by writing /assign @dcbw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[juanluisvaladas]

/retitle Bug 1782303: Bump library go

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782303, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1782303: Bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

@juanluisvaladas why do we need this in 4.3?

[juanluisvaladas]

To have oc explain working, not quite sure how big a deal this is, but since @knobunc opened the bug and it looks like a few straightforward cherry-picks I didn't question much.

[danwinship]

To have oc explain working

Are we sure it wasn't before? I had thought the problem only existed in 4.4, but maybe it's that the problem always existed and was only exposed in 4.4 because of new tests?

it looks like a few straightforward cherry-picks

It's 130,000 lines of diff because of the vendor changes. (Did you actually just cherry-pick that? If so you probably ended up getting too-new versions of some dependencies. Although it looks like we don't properly version them in Gopkg.toml so you'd probably get too-new versions if you revendored "properly" too...)

At any rate, doesn't this depend on changes that were made in openshift/api that were not backported to release-4.3 there? (eg, openshift/api#527)

[juanluisvaladas]

Are we sure it wasn't before? I had thought the problem only existed in 4.4, but maybe it's that the problem always existed and was only exposed in 4.4 because of new tests?

The problem existed before and the new tests were introduced in 4.3, but they were disabled:
openshift/origin#24222
By the time this was fixed it was 4.4 already.

It's 130,000 lines of diff because of the vendor changes. (Did you actually just cherry-pick that? If so you probably ended up getting too-new versions of some dependencies. Although it looks like we don't properly version them in Gopkg.toml so you'd probably get too-new versions if you revendored "properly" too...)

release-4.4 still references kubernetes 1.16 so I just assumed if the tests passed, it would be fine.

At any rate, doesn't this depend on changes that were made in openshift/api that were not backported to release-4.3 there? (eg, openshift/api#527)

You're right.
/hold

I thought this would be something quick and straightforward, but turns out there is more complexity than I expected. Before doing any actual work, how much do we care about oc explain not working on 4.3?

On a side note, looks like there is quite a bit of a mess with dependencies (we should stop referencing master and probably 4.4 ought to be referencing kubernetes 1.17).

[danwinship]

Before doing any actual work, how much do we care about oc explain not working on 4.3?

Probably not enough to be worth dealing with all this

On a side note, looks like there is quite a bit of a mess with dependencies (we should stop referencing master and probably 4.4 ought to be referencing kubernetes 1.17).

yup

[openshift-ci-robot]

@openshift-cherrypick-robot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[juanluisvaladas]

/close

Ben agreed it's not worth the trouble.

[openshift-ci-robot]

@juanluisvaladas: Closed this PR.

In response to this:

/close

Ben agreed it's not worth the trouble.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.