Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use app label instead of name on ovnkube-master ds #419

Merged
merged 1 commit into from Dec 19, 2019
Merged

Use app label instead of name on ovnkube-master ds #419

merged 1 commit into from Dec 19, 2019

Conversation

rcarrillocruz
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2019
@danwinship
Copy link
Contributor

/test e2e-aws-ovn

@rcarrillocruz
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor

/lgtm
/hold
until e2e-aws-ovn passes, feel free to cancel hold when it does

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2019
pecameron
pecameron reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@pecameron pecameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pecameron
Copy link
Contributor

/test e2e-aws-ovn

1 similar comment
@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@rcarrillocruz
Copy link
Contributor Author

/test e2e-gcp-upgrade

@rcarrillocruz
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@danwinship
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@danwinship
Copy link
Contributor

/test e2e-aws-ovn

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2019
@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@rcarrillocruz
Copy link
Contributor Author

/retest

@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@danwinship
Copy link
Contributor

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 18, 2019
@rcarrillocruz
Copy link
Contributor Author

/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@rcarrillocruz
Copy link
Contributor Author

/retest

@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

3 similar comments
@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@rcarrillocruz
Copy link
Contributor Author

/test e2e-aws-ovn

@squeed
Copy link
Contributor

squeed commented Dec 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, pecameron, rcarrillocruz, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 42a5b6d into openshift:master Dec 19, 2019
dcbw added a commit to dcbw/cluster-network-operator that referenced this pull request Dec 28, 2019
@dcbw
ovn: use app label instead of name for master metrics and quorum guard
ab9f0fc 
Finish what openshift#419
was trying to do. We need all the master things to use 'app' not 'name'
for metrics scraping to work correctly.
@dcbw dcbw mentioned this pull request Dec 28, 2019
Merged
@danwinship danwinship mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pecameron pecameron pecameron left review comments

@danwinship danwinship Awaiting requested review from danwinship

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@danwinship danwinship

@squeed squeed

@pecameron pecameron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rcarrillocruz @danwinship @pecameron @openshift-bot @squeed @openshift-ci-robot @openshift-merge-robot