Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovn: use app label instead of name for master metrics and quorum guard #435

Merged
merged 1 commit into from Dec 28, 2019
Merged

ovn: use app label instead of name for master metrics and quorum guard #435

merged 1 commit into from Dec 28, 2019

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Dec 28, 2019 •
edited

Finish what #419 was trying to do. We need all the master things to use 'app' not 'name' for metrics scraping to work correctly.

@JacobTanenbaum @danwinship @juanluisvaladas @alexanderConstantinescu @rcarrillocruz @pecameron

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2019
@dcbw
ovn: use app label instead of name for master metrics and quorum guard
ab9f0fc 
Finish what openshift#419
was trying to do. We need all the master things to use 'app' not 'name'
for metrics scraping to work correctly.
@dcbw dcbw force-pushed the fix-master-metrics-scraping branch from 2e3d9e1 to ab9f0fc Compare December 28, 2019 21:57
@dcbw dcbw changed the title ovn: name->app in ServiceMonitor, Service, and DaemonSet for ovnkube-master ovn: use app label instead of name for master metrics and quorum guard Dec 28, 2019
@dcbw
Copy link
Member Author

dcbw commented Dec 28, 2019

/test e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@dcbw: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ovn ab9f0fc link /test e2e-aws-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw dcbw merged commit 2fb841d into openshift:master Dec 28, 2019
This was referenced Dec 29, 2019
Merged
Merged
@vrutkovs
Copy link
Member

This breaks OVN upgrades, since CVO uses apply and label selectors are immutable

@danwinship danwinship mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@pecameron pecameron Awaiting requested review from pecameron

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcbw @openshift-ci-robot @vrutkovs