Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1769015: Add preserveUnknownFields to CRDs #458

Merged
merged 1 commit into from Jan 30, 2020

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jan 29, 2020

It turns out the bug was failing validation because the implementation of explain barfs if the crd schema doesn't have the preserveUnknownFields in the spec.

PR openshift/origin#24477 may need some rework after this merges.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 29, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1769015, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1769015: Add preserveUnknownFields to CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2020
@dcbw
Copy link
Member

dcbw commented Jan 29, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@abhat
Copy link
Contributor Author

abhat commented Jan 30, 2020

/test e2e-gcp-upgrade

@openshift-merge-robot openshift-merge-robot merged commit 20853b6 into openshift:master Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: All pull requests linked via external trackers have merged. Bugzilla bug 1769015 has been moved to the MODIFIED state.

In response to this:

Bug 1769015: Add preserveUnknownFields to CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants