Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796234: Move the oc explain tests for networking CRDs to a new test #24477

Merged
merged 2 commits into from Jan 30, 2020
Merged

Bug 1796234: Move the oc explain tests for networking CRDs to a new test #24477

merged 2 commits into from Jan 30, 2020

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jan 29, 2020 •
edited

Networking CRDs such as clusternetworks, hostsubnets, egressnetworkpolicies etc. don't apply to OVNKubernetes, so the oc explain tests need to be split into two.

This PR adds a new test so that the verification of oc explain output for these CRDs can be skipped for OVNKubernetes.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2020
@vrutkovs
Copy link
Member

/test e2e-aws-ovn

1 similar comment
@abhat
Copy link
Contributor Author

abhat commented Jan 29, 2020

/test e2e-aws-ovn

@abhat
Copy link
Contributor Author

abhat commented Jan 29, 2020

/test images
/test e2e-aws-serial
/test e2e-gcp-builds

@abhat abhat mentioned this pull request Jan 29, 2020
Merged
@abhat
Copy link
Contributor Author

abhat commented Jan 29, 2020

/test e2e-gcp-builds

@abhat abhat changed the title Move the oc explain tests for networking CRDs to a new test Bug 1796234: Move the oc explain tests for networking CRDs to a new test Jan 29, 2020
@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1796234, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796234: Move the oc explain tests for networking CRDs to a new test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 29, 2020
@abhat
Copy link
Contributor Author

abhat commented Jan 29, 2020

/test e2e-aws-ovn

@abhat
Copy link
Contributor Author

abhat commented Jan 29, 2020

/test e2e-aws-ovn

@abhat
Copy link
Contributor Author

abhat commented Jan 30, 2020

/test e2e-aws-ovn
/test e2e-cmd

@abhat
Copy link
Contributor Author

abhat commented Jan 30, 2020

/test e2e-gcp-builds

@abhat
Copy link
Contributor Author

abhat commented Jan 30, 2020

/test e2e-aws-fips
/test e2e-gcp
/test e2e-aws-serial

@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

/test e2e-gcp
/test e2e-aws-serial
/test e2e-aws-fips

@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

seems to be flakes in gcp test
/retest

@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@knobunc
Copy link
Contributor

knobunc commented Jan 30, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, dcbw, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@dcbw
Copy link
Contributor

dcbw commented Jan 30, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit c3fc820 into openshift:master Jan 30, 2020
@openshift-ci-robot
Copy link

@abhat: All pull requests linked via external trackers have merged. Bugzilla bug 1796234 has been moved to the MODIFIED state.

In response to this:

Bug 1796234: Move the oc explain tests for networking CRDs to a new test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat abhat deleted the fix_e2e_explain_test branch January 30, 2020 15:16
This was referenced Jan 30, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs left review comments

@dcbw dcbw dcbw left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abhat @vrutkovs @openshift-ci-robot @dcbw @knobunc @openshift-merge-robot