Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit #460

Merged
merged 1 commit into from Feb 1, 2020
Merged

Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit #460

merged 1 commit into from Feb 1, 2020

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Jan 30, 2020

When terminated gracefully, either via 'ovs-ctl stop' or TERM,
ovs-vswitchd cleans up datapath flows. This prevents any existing
flows from continuing to work, which kinda defeats the purpose of
a seamless upgrade.

@orgcandman @knobunc @danwinship @rcarrillocruz @smarterclayton

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2020
@knobunc
Copy link
Contributor

knobunc commented Jan 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@dcbw dcbw changed the title sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1796562, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 30, 2020
@dcbw dcbw changed the title Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit [wip] Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit Jan 30, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@juanluisvaladas
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@danwinship
Copy link
Contributor

hm... we shouldn't need the preStop hook should we? Trapping SIGTERM should be sufficient. (This isn't new; it's redundant in the old code too, I just hadn't noticed it before.)

@dcbw
sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit
2f543fa 
When terminated gracefully, either via 'ovs-ctl stop' or TERM,
ovs-vswitchd cleans up datapath flows. This prevents any existing
flows from continuing to work, which kinda defeats the purpose of
a seamless upgrade.

The preStop hook is removed because it is redundant with the
TERM trap of the container's main process bash script.
@dcbw
Copy link
Member Author

dcbw commented Jan 31, 2020

hm... we shouldn't need the preStop hook should we? Trapping SIGTERM should be sufficient. (This isn't new; it's redundant in the old code too, I just hadn't noticed it before.)

@danwinship I think you're right, so I removed it.

@dcbw
Copy link
Member Author

dcbw commented Jan 31, 2020

/test e2e-aws-ovn

@dcbw
Copy link
Member Author

dcbw commented Jan 31, 2020

/test e2e-gcp

@juanluisvaladas
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, juanluisvaladas, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcbw
Copy link
Member Author

dcbw commented Jan 31, 2020

Flake:
[Feature:Builds] forcePull should affect pulling builder images [Top Level] [Feature:Builds] forcePull should affect pulling builder images ForcePull test case execution s2i [Suite:openshift/conformance/parallel]

/retest

@dcbw dcbw changed the title [wip] Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit Jan 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dcbw
Copy link
Member Author

dcbw commented Jan 31, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dcbw
Copy link
Member Author

dcbw commented Jan 31, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5cd9bb8 into openshift:master Feb 1, 2020
@openshift-ci-robot
Copy link
Contributor

@dcbw: All pull requests linked via external trackers have merged. Bugzilla bug 1796562 has been moved to the MODIFIED state.

In response to this:

Bug 1796562: sdn/ovn: don't allow ovs-vswitchd to clean up datapath flows on exit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@juanluisvaladas juanluisvaladas

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dcbw @knobunc @openshift-ci-robot @juanluisvaladas @danwinship @openshift-bot @openshift-merge-robot