Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Progressing message for non-critical components #510

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Update Progressing message for non-critical components #510

merged 1 commit into from
Mar 19, 2020

Conversation

danwinship
Copy link
Contributor

I was backporting #474 and realized that it solves DaemonSet "openshift-multus/multus-admission-controller" is not available ... (ie, "your install failed after the worker nodes were created but before multus-admission-controller could be deployed") but not DaemonSet "openshift-multus/multus-admission-controller" is not yet scheduled on any nodes (ie, "your install failed before the worker nodes were created").

(WIP until I see it doing the right thing in a test run)

@danwinship danwinship requested a review from dougbtv March 3, 2020 20:22
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2020
@danwinship
Copy link
Contributor Author

/retest

1 similar comment
@danwinship
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor Author

Statuses:

Waiting for DaemonSet "openshift-multus/multus-admission-controller" to be created
DaemonSet "openshift-multus/multus-admission-controller" is waiting for other operators to become ready
DaemonSet "..." update is rolling out (0 out of 1 updated)
DaemonSet "..." is waiting for other operators to become ready
DaemonSet "..." is not available (awaiting 2 nodes)
DaemonSet "..." is not available (awaiting 1 nodes)
Progressing -> False

so this is not quite right. It shouldn't go back to "waiting for other operators" after it stops that.

@danwinship danwinship force-pushed the multus-admission-progressing-2 branch from 87508cc to 5847a61 Compare March 9, 2020 17:06
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2020
This was referenced Mar 9, 2020
Closed
Closed
@danwinship danwinship force-pushed the multus-admission-progressing-2 branch from 5847a61 to 092c87b Compare March 9, 2020 19:41
@danwinship danwinship changed the title WIP Update Progressing message for non-critical components Update Progressing message for non-critical components Mar 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2020
@danwinship
Copy link
Contributor Author

ok, now we get:

Waiting for DaemonSet "openshift-multus/multus-admission-controller" to be created
DaemonSet "openshift-multus/multus-admission-controller" is waiting for other operators to become ready
DaemonSet "openshift-multus/multus-admission-controller" update is rolling out (0 out of 1 updated)
DaemonSet "openshift-multus/multus-admission-controller" is not available (awaiting 1 nodes)
DaemonSet "openshift-multus/multus-admission-controller" is not available (awaiting 2 nodes)
DaemonSet "openshift-multus/multus-admission-controller" update is rolling out (2 out of 3 updated)
DaemonSet "openshift-multus/multus-admission-controller" is not available (awaiting 3 nodes)
DaemonSet "openshift-multus/multus-admission-controller" is not available (awaiting 2 nodes)
DaemonSet "openshift-multus/multus-admission-controller" is not available (awaiting 1 nodes)

Progressing -> False

which is still a little weird, but it's consistent with our other reporting, which we ought to improve at some point. But (1) it stays at "waiting for other operators" until it starts being deployed, and (2) it doesn't go back to "waiting for other operators" after that.

@danwinship
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor Author

/assign @dougbtv

@danwinship
Copy link
Contributor Author

/retest

@dcbw
Copy link
Contributor

dcbw commented Mar 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b29809e into openshift:master Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

@danwinship: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn 092c87b link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Mar 20, 2020
Closed
Merged
@danwinship danwinship deleted the multus-admission-progressing-2 branch March 24, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@squeed squeed Awaiting requested review from squeed

Assignees

@dougbtv dougbtv

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danwinship @dcbw @openshift-ci-robot @openshift-bot @dougbtv @openshift-merge-robot