Bug 1829233: Recreate DNS service upon Octavia upgrade #607

MaysaMacedo · 2020-04-26T12:02:31Z

When Octavia is upgraded from OSP13 to OSP16 double listeners becomes
supported and the load balancers that requires TCP and UDP on same
port should be recreated.

This commit ensure the DNS service is recreated upon Octavia upgrade.

MaysaMacedo · 2020-04-27T18:38:03Z

Verified the DNS service is recreated upon upgrade

dulek · 2020-04-28T07:29:58Z

Don't we need bug tied to this if we're planning to backport it?

pkg/platform/openstack/kuryr_bootstrap.go

openshift-ci-robot · 2020-04-29T09:18:04Z

@MaysaMacedo: This pull request references Bugzilla bug 1829233, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1829233: Recreate DNS service upon Octavia upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/platform/openstack/kuryr_bootstrap.go

When Octavia is upgraded from OSP13 to OSP16 double listeners becomes supported and the load balancers that requires TCP and UDP on same port should be recreated. This commit ensure the DNS service is recreated upon Octavia upgrade.

MaysaMacedo · 2020-04-30T11:01:03Z

/retest

luis5tb · 2020-05-05T08:58:00Z

/lgtm

dulek · 2020-05-05T10:27:03Z

/approve

MaysaMacedo · 2020-05-05T10:50:15Z

/assign @squeed

squeed · 2020-05-05T12:16:03Z

pkg/platform/openstack/kuryr_bootstrap.go

+		savedOctaviaVersion := semver.MustParse(octaviaVersion)
+		multipleListenersVersion := semver.MustParse(MinOctaviaVersionWithMultipleListeners)
+		if !savedOctaviaVersion.Equal(maxOctaviaVersion) && savedOctaviaVersion.LessThan(multipleListenersVersion) && octaviaMultipleListenersSupport {
+			dnsService := &v1.Service{


Will this cause disruption to the cluster?

It will cause a small downtime of few seconds on the DNS resolution, as a new load balancer with the double listeners is getting created. After the load balancer is in place, the cluster should work normally.

with amphora octavia driver I would say not just a few seconds, but around a minute. Note though this only happens upon OpenStack octavia upgrade between octavia version not supporting UDP to the one supporting it -- on the same port as the TCP one.

That is... a bit concerning. What are the end-user expectations around this upgrade?

The path for Octavia upgrade from version 13 to 16 is still in progress.
Octavia team suggestion for the problem being solved here is to make the operator open a support ticket requesting for the upgrade of a Load Balancer. However, we can't rely on that as our approach for enforcing DNS resolution over TCP would be gone as soon as the upgrade happens.

We expect to work on other approaches for this solution to make it more ideal in following releases.

luis5tb · 2020-05-19T08:39:34Z

/test e2e-gcp-ovn

squeed · 2020-05-19T11:13:56Z

/override ci/prow/e2e-gcp-ovn
(Because this is an Octavia change)

openshift-ci-robot · 2020-05-19T11:14:20Z

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn
(Because this is an Octavia change)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc · 2020-05-20T15:44:17Z

/approve

openshift-ci-robot · 2020-05-20T15:45:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, knobunc, luis5tb, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-20T17:24:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-20T18:55:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

MaysaMacedo · 2020-05-20T19:16:47Z

/hold
Let me just perform one last test prior to merging it.

MaysaMacedo · 2020-05-27T12:30:32Z

/hold cancel

luis5tb · 2020-05-27T13:50:44Z

/test e2e-gcp

MaysaMacedo · 2020-05-27T15:13:03Z

/test e2e-gcp

openshift-bot · 2020-05-27T17:04:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-27T17:29:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-05-27T18:29:31Z

@MaysaMacedo: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#607. Bugzilla bug 1829233 has been moved to the MODIFIED state.

In response to this:

Bug 1829233: Recreate DNS service upon Octavia upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MaysaMacedo · 2020-05-28T07:38:38Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-05-28T07:38:43Z

@MaysaMacedo: #607 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	bindata/network/kuryr/003-config.yaml
M	pkg/platform/openstack/kuryr_bootstrap.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/platform/openstack/kuryr_bootstrap.go
CONFLICT (content): Merge conflict in pkg/platform/openstack/kuryr_bootstrap.go
Auto-merging bindata/network/kuryr/003-config.yaml
Patch failed at 0001 Recreate DNS service upon Octavia upgrade

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from dcbw and dulek April 26, 2020 12:02

MaysaMacedo force-pushed the delete-dns-svc-on-upgrade branch from f8a01eb to 0fd4ca6 Compare April 26, 2020 12:07

MaysaMacedo changed the title ~~Recreate DNS service upon Octavia upgrade~~ wip: Recreate DNS service upon Octavia upgrade Apr 26, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2020

MaysaMacedo changed the title ~~wip: Recreate DNS service upon Octavia upgrade~~ Recreate DNS service upon Octavia upgrade Apr 27, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2020

dulek suggested changes Apr 28, 2020

View reviewed changes

pkg/platform/openstack/kuryr_bootstrap.go Outdated Show resolved Hide resolved

MaysaMacedo force-pushed the delete-dns-svc-on-upgrade branch 2 times, most recently from 9db4d7b to 5fe5406 Compare April 29, 2020 08:55

MaysaMacedo changed the title ~~Recreate DNS service upon Octavia upgrade~~ Bug 1829233: Recreate DNS service upon Octavia upgrade Apr 29, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 29, 2020

luis5tb reviewed Apr 30, 2020

View reviewed changes

pkg/platform/openstack/kuryr_bootstrap.go Outdated Show resolved Hide resolved

luis5tb reviewed Apr 30, 2020

View reviewed changes

pkg/platform/openstack/kuryr_bootstrap.go Outdated Show resolved Hide resolved

Recreate DNS service upon Octavia upgrade

56e5da0

When Octavia is upgraded from OSP13 to OSP16 double listeners becomes supported and the load balancers that requires TCP and UDP on same port should be recreated. This commit ensure the DNS service is recreated upon Octavia upgrade.

MaysaMacedo force-pushed the delete-dns-svc-on-upgrade branch from 5fe5406 to 56e5da0 Compare April 30, 2020 08:30

openshift-ci-robot assigned luis5tb May 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020

openshift-ci-robot assigned squeed May 5, 2020

squeed reviewed May 5, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020

openshift-merge-robot merged commit 47490e0 into openshift:master May 27, 2020

MaysaMacedo deleted the delete-dns-svc-on-upgrade branch May 27, 2020 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1829233: Recreate DNS service upon Octavia upgrade #607

Bug 1829233: Recreate DNS service upon Octavia upgrade #607

MaysaMacedo commented Apr 26, 2020

MaysaMacedo commented Apr 27, 2020 •

edited

Loading

dulek commented Apr 28, 2020

openshift-ci-robot commented Apr 29, 2020

MaysaMacedo commented Apr 30, 2020

luis5tb commented May 5, 2020

dulek commented May 5, 2020

MaysaMacedo commented May 5, 2020

squeed May 5, 2020

MaysaMacedo May 5, 2020

luis5tb May 5, 2020

squeed May 19, 2020

MaysaMacedo May 27, 2020

luis5tb commented May 19, 2020

squeed commented May 19, 2020

openshift-ci-robot commented May 19, 2020

knobunc commented May 20, 2020

openshift-ci-robot commented May 20, 2020

openshift-bot commented May 20, 2020

openshift-bot commented May 20, 2020

MaysaMacedo commented May 20, 2020

MaysaMacedo commented May 27, 2020

luis5tb commented May 27, 2020

MaysaMacedo commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-ci-robot commented May 27, 2020

MaysaMacedo commented May 28, 2020

openshift-cherrypick-robot commented May 28, 2020

Bug 1829233: Recreate DNS service upon Octavia upgrade #607

Bug 1829233: Recreate DNS service upon Octavia upgrade #607

Conversation

MaysaMacedo commented Apr 26, 2020

MaysaMacedo commented Apr 27, 2020 • edited Loading

dulek commented Apr 28, 2020

openshift-ci-robot commented Apr 29, 2020

MaysaMacedo commented Apr 30, 2020

luis5tb commented May 5, 2020

dulek commented May 5, 2020

MaysaMacedo commented May 5, 2020

squeed May 5, 2020

Choose a reason for hiding this comment

MaysaMacedo May 5, 2020

Choose a reason for hiding this comment

luis5tb May 5, 2020

Choose a reason for hiding this comment

squeed May 19, 2020

Choose a reason for hiding this comment

MaysaMacedo May 27, 2020

Choose a reason for hiding this comment

luis5tb commented May 19, 2020

squeed commented May 19, 2020

openshift-ci-robot commented May 19, 2020

knobunc commented May 20, 2020

openshift-ci-robot commented May 20, 2020

openshift-bot commented May 20, 2020

openshift-bot commented May 20, 2020

MaysaMacedo commented May 20, 2020

MaysaMacedo commented May 27, 2020

luis5tb commented May 27, 2020

MaysaMacedo commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-bot commented May 27, 2020

openshift-ci-robot commented May 27, 2020

MaysaMacedo commented May 28, 2020

openshift-cherrypick-robot commented May 28, 2020

MaysaMacedo commented Apr 27, 2020 •

edited

Loading