-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1832305: Kuryr: Remove old SG rules on upgrade #619
Bug 1832305: Kuryr: Remove old SG rules on upgrade #619
Conversation
@dulek: This pull request references Bugzilla bug 1832311, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dulek: This pull request references Bugzilla bug 1832305, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dulek: This pull request references Bugzilla bug 1832305, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
{masterSgId, openStackSvcCIDR, etcdPort, etcdPort, rules.ProtocolTCP}, | ||
{masterSgId, openStackSvcCIDR, apiPort, apiPort, rules.ProtocolTCP}, | ||
} | ||
|
||
var decommissionedRules = []sgRule{ | ||
{podSgId, workerSubnet.CIDR, 0, 0, ""}, | ||
{masterSgId, openStackSvcCIDR, 2379, 2380, rules.ProtocolTCP}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't these the etcd ports? shouldn't we remove other ranges not this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule from 4.3 got replaced by a rule opening just 2379 in 4.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right!
{masterSgId, openStackSvcCIDR, etcdPort, etcdPort, rules.ProtocolTCP}, | ||
{masterSgId, openStackSvcCIDR, apiPort, apiPort, rules.ProtocolTCP}, | ||
} | ||
|
||
var decommissionedRules = []sgRule{ | ||
{podSgId, workerSubnet.CIDR, 0, 0, ""}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be the other way around? removing the access from the pods to the workers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
In order to support updates in the SG rules added on Kuryr bootstrap we need to make sure the security groups that got replaced by others are removed. This commit, by maintaing list of "decommissioned" SG rules, will make sure we delete them on upgrade.
3cef544
to
d71ff27
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, gryf, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dulek: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dulek: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#619. Bugzilla bug 1832305 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@dulek: #619 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In order to support updates in the SG rules added on Kuryr bootstrap we
need to make sure the security groups that got replaced by others are
removed. This commit, by maintaing list of "decommissioned" SG rules,
will make sure we delete them on upgrade.