Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multus whereabouts IPAM CNI should support overlapping ranges #726

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Multus whereabouts IPAM CNI should support overlapping ranges #726

merged 1 commit into from
Jul 24, 2020

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Jul 23, 2020

This change applies a new CRD and the appropriate RBAC permission to enable
functionality in Whereabouts IPAM CNI which enables the use of overlapping
ranges without re-assigning IP addresses across ranges.

@dougbtv
Multus whereabouts IPAM CNI should support overlapping ranges
9185cf4 
This change applies a new CRD and the appropriate RBAC permission to enable
functionality in Whereabouts IPAM CNI which enables the use of overlapping
ranges without re-assigning IP addresses across ranges.
@dougbtv dougbtv force-pushed the whereabouts-overlapping-ranges branch from 751a0f1 to 9185cf4 Compare July 23, 2020 13:08
@dougbtv
Copy link
Member Author

dougbtv commented Jul 23, 2020

/test e2e-gcp-upgrade
/test e2e-gcp-ovn

@dougbtv
Copy link
Member Author

dougbtv commented Jul 24, 2020

/test e2e-gcp-ovn

knobunc
knobunc approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (not /lgtming so someone else can weigh in)
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@juanluisvaladas
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, juanluisvaladas, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2020 •
edited
Loading

@dougbtv: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 9185cf4 link /test e2e-openstack
ci/prow/e2e-azure 9185cf4 link /test e2e-azure
ci/prow/e2e-vsphere 9185cf4 link /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7303c68 into openshift:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@danielmellado danielmellado Awaiting requested review from danielmellado

@danwinship danwinship Awaiting requested review from danwinship

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

Assignees

@juanluisvaladas juanluisvaladas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dougbtv @juanluisvaladas @openshift-ci-robot @openshift-bot @knobunc @openshift-merge-robot