Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1890130: openshift-sdn: multitenant: join openshift-etcd-operator to etcd #844

Merged
merged 1 commit into from Oct 27, 2020

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Oct 21, 2020

It needs to be able to reach etcd, so it needs to be in netns 1.

Fixes: bz 1890130

@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1890130, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1890130: openshift-sdn: multitenant: join openshift-etcd-operator to etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 21, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@juanluisvaladas
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor Author

squeed commented Oct 21, 2020

/skip ci/prow/e2e-gcp-ovn

no ovn changes.

@squeed
Copy link
Contributor Author

squeed commented Oct 21, 2020

well, the multitenant cluster has come up and seems mostly fine, but we might have a bit more whack-a-mole to find connection issues.

@squeed
Copy link
Contributor Author

squeed commented Oct 21, 2020

looks like one node went unreachable in run - investigating (though this change couldn't have caused that)

/test e2e-aws-sdn-multi

@squeed
Copy link
Contributor Author

squeed commented Oct 21, 2020

update: no real useful information; of course the node's logs are inaccessible. It's a worker node, so definitely not affected by this change.

@squeed
Copy link
Contributor Author

squeed commented Oct 21, 2020

/cherrypick release-4.6

@openshift-cherrypick-robot

@squeed: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor Author

squeed commented Oct 21, 2020

/cherrypick release-4.5

@openshift-cherrypick-robot

@squeed: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor Author

squeed commented Oct 22, 2020

argh, it looks like load took down a node:

RunPodSandbox from runtime service failed: rpc error: code = Unknown desc = Kubelet may be retrying requests that are timing out in CRI-O due to system load

I think this will go in, eventually.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanluisvaladas
Copy link
Contributor

@squeed
Copy link
Contributor Author

squeed commented Oct 22, 2020

/test e2e-aws-sdn-multi

@squeed
Copy link
Contributor Author

squeed commented Oct 22, 2020

ordinarily I would just /skip this, but given that this is literally the CI job I'm trying to fix...

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor Author

squeed commented Oct 26, 2020

still crio creation timing out; this is really weird. Again, it doesn't immediately seem like a problem caused by my change.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

It needs to be able to reach etcd, so it needs to be in netns 1.

Fixes: bz 1890130
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@squeed
Copy link
Contributor Author

squeed commented Oct 26, 2020

/hold
something is definitely wrong; bumping osdn verbosity.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2020
@danwinship
Copy link
Contributor

/skip ci/prow/e2e-gcp-ovn

(the word you're looking for is /override)

@squeed
Copy link
Contributor Author

squeed commented Oct 26, 2020

An update: I think there's a deadlock in openshift-sdn in multitenant mode. This PR exposes it, but I can't fix it in this repository.

I think we should force-merge this, so the test results are meaningful

@squeed
Copy link
Contributor Author

squeed commented Oct 26, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2020
@knobunc
Copy link
Contributor

knobunc commented Oct 26, 2020

/retest

@knobunc
Copy link
Contributor

knobunc commented Oct 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, knobunc, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 26, 2020

@squeed: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn 1f4c009 link /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squeed
Copy link
Contributor Author

squeed commented Oct 27, 2020

It looks like multitenant mode is stuck on an sdn deadlock. Given that this change doesn't break anything, and gets us closer to fixing openshift-sdn multitenant, I'm going to override the job so we can make progress.

/override ci/prow/e2e-aws-sdn-multi
/override ci/prow/e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-aws-sdn-multi, ci/prow/e2e-gcp-ovn

In response to this:

It looks like multitenant mode is stuck on an sdn deadlock. Given that this change doesn't break anything, and gets us closer to fixing openshift-sdn multitenant, I'm going to override the job so we can make progress.

/override ci/prow/e2e-aws-sdn-multi
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0e4fd4e into openshift:master Oct 27, 2020
@openshift-ci-robot
Copy link
Contributor

@squeed: All pull requests linked via external trackers have merged:

Bugzilla bug 1890130 has been moved to the MODIFIED state.

In response to this:

Bug 1890130: openshift-sdn: multitenant: join openshift-etcd-operator to etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@squeed: new pull request created: #850

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@squeed: new pull request created: #851

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@squeed: new pull request created: #855

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants