New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1890130: openshift-sdn: multitenant: join openshift-etcd-operator to etcd #844
Bug 1890130: openshift-sdn: multitenant: join openshift-etcd-operator to etcd #844
Conversation
@squeed: This pull request references Bugzilla bug 1890130, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
/skip ci/prow/e2e-gcp-ovn no ovn changes. |
well, the multitenant cluster has come up and seems mostly fine, but we might have a bit more whack-a-mole to find connection issues. |
looks like one node went unreachable in run - investigating (though this change couldn't have caused that) /test e2e-aws-sdn-multi |
update: no real useful information; of course the node's logs are inaccessible. It's a worker node, so definitely not affected by this change. |
/cherrypick release-4.6 |
@squeed: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.5 |
@squeed: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
argh, it looks like load took down a node:
I think this will go in, eventually. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Thje pod predicate nodeports error also happens in networkpolicy, we can ignore this. |
/test e2e-aws-sdn-multi |
ordinarily I would just |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
still crio creation timing out; this is really weird. Again, it doesn't immediately seem like a problem caused by my change. |
/retest Please review the full test history for this PR and help us cut down flakes. |
It needs to be able to reach etcd, so it needs to be in netns 1. Fixes: bz 1890130
/hold |
(the word you're looking for is |
An update: I think there's a deadlock in openshift-sdn in multitenant mode. This PR exposes it, but I can't fix it in this repository. I think we should force-merge this, so the test results are meaningful |
/hold cancel |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanluisvaladas, knobunc, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@squeed: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It looks like multitenant mode is stuck on an sdn deadlock. Given that this change doesn't break anything, and gets us closer to fixing openshift-sdn multitenant, I'm going to override the job so we can make progress. /override ci/prow/e2e-aws-sdn-multi |
@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-aws-sdn-multi, ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@squeed: All pull requests linked via external trackers have merged: Bugzilla bug 1890130 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@squeed: new pull request created: #850 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@squeed: new pull request created: #851 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@squeed: new pull request created: #855 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It needs to be able to reach etcd, so it needs to be in netns 1.
Fixes: bz 1890130