Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1890130: fix pod creation deadlock #209

Merged
merged 1 commit into from Nov 2, 2020
Merged

Bug 1890130: fix pod creation deadlock #209

merged 1 commit into from Nov 2, 2020

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Oct 28, 2020

Commit b5f89a6 introduced a deadlock on pod creation, but only for multitenant mode.

The fix is to lock runningPods as late as possible.

Fixes: 1890130

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 28, 2020
@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1890130, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1890130: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

/test e2e-aws-multi

@openshift-ci-robot
Copy link
Contributor

@squeed: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-multitenant
  • /test e2e-aws-upgrade
  • /test e2e-gcp
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run the following jobs:

  • pull-ci-openshift-sdn-master-e2e-aws
  • pull-ci-openshift-sdn-master-e2e-aws-upgrade
  • pull-ci-openshift-sdn-master-e2e-gcp
  • pull-ci-openshift-sdn-master-images
  • pull-ci-openshift-sdn-master-unit
  • pull-ci-openshift-sdn-master-verify
  • pull-ci-openshift-sdn-master-verify-deps

In response to this:

/test e2e-aws-multi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

/test e2e-aws-multitenant

@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

/cc @danwinship, since he reviewed the PR that caused this bug :-)

@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

Single test failed; GCP issue:

Failed to setup provider config for "gce": Error building GCE/GKE provider: unexpected response listing zones: googleapi: Error 503: The service is currently unavailable.

/retest

@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

More importantly, e2e-aws-multitenant is green (and we don't appear to have regressed networkpolicy).

@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

/cherry-pick release-4.6
/cherry-pick release-4.5
/cherry-pick release-4.4
/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

@squeed: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6
/cherry-pick release-4.5
/cherry-pick release-4.4
/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship
danwinship reviewed Oct 28, 2020
View reviewed changes
pkg/network/node/pod.go Outdated Show resolved Hide resolved
@squeed
fix pod creation deadlock
c620009 
Commit b5f89a6 introduced a deadlock on pod creation, but only for
multitenant mode.

The fix is to lock runningPods only when actually accessing it, rather than
broadly.

Fixes: 1890130
@squeed
Copy link
Contributor Author

squeed commented Oct 28, 2020

CI all green, just needs lgtm from someone.

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8e0c9b4 into openshift:master Nov 2, 2020
@openshift-ci-robot
Copy link
Contributor

@squeed: All pull requests linked via external trackers have merged:

Bugzilla bug 1890130 has been moved to the MODIFIED state.

In response to this:

Bug 1890130: fix pod creation deadlock

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 2, 2020
Merged
@openshift-cherrypick-robot
Copy link

@squeed: new pull request created: #213

In response to this:

/cherry-pick release-4.6
/cherry-pick release-4.5
/cherry-pick release-4.4
/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@squeed @openshift-ci-robot @openshift-cherrypick-robot @danwinship @openshift-bot @openshift-merge-robot