Bug 1912409: Fix flow schema deployment #920
Conversation
PR: openshift#880 added a deployment stanza for a specific kubernetes feature, but only did that for openshift-sdn and not for ovn-kubernetes, moreover it added it in the wrong place independently of the network plugin being deployed Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
There was a problem hiding this comment.
feature documentation is https://kubernetes.io/docs/concepts/cluster-administration/flow-control/
It looks like this is supposed to say "requests made by the given ServiceAccounts have system priority", which I believe is the highest priority level. OK. I agree that both the controller and the node service accounts should be high priority for both openshift-sdn and ovn-kubernetes.
| metadata: | ||
| name: openshift-ovn-kubernetes | ||
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" |
There was a problem hiding this comment.
This annotation only makes sense for things in manifests/ (so should be removed both here and from the sdn one)
There was a problem hiding this comment.
ACK, will change.
|
|
/assign @deads2k |
No, I just moved the sdn flowschema to |
I can't speak to the operator logic, but as far as the kube-apiserver and p&f are concerned, there is no dependency. A flowschema object can be created even though the specified user/service account do not exist yet. |
|
@alexanderConstantinescu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold Not sure why it's been re-running all jobs when all required ones have already passed. Also not sure why I need a valid bug for getting this stuff in on master. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retitle Bug 1912409: Fix flow schema deployment |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@alexanderConstantinescu: This pull request references Bugzilla bug 1912409, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexanderConstantinescu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexanderConstantinescu: All pull requests linked via external trackers have merged: Bugzilla bug 1912409 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,37 @@ | |||
| apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 | |||
There was a problem hiding this comment.
this must not use v1alpha1. v1alpha1 is subject to going away. Please switch to v1beta1 asap.
There was a problem hiding this comment.
OK, I will file a PR momentarily for that. Thanks for letting us now
There was a problem hiding this comment.
@alexanderConstantinescu based on the discussion with @sttts we should leave the version to v1alpha1 for 4.7. We should set the version to v1beta1 in 4.8.
Please see https://bugzilla.redhat.com/show_bug.cgi?id=1913399#c1
PR: #880 added a deployment stanza for a specific kubernetes feature, but only did that for openshift-sdn and not for ovn-kubernetes, moreover it added it in the wrong place independently of the network plugin being deployed.
I have no idea how this works and if the sequence of deployment is important or not for this stuff, so @tkashem could you please advise?
/assign @danwinship