Bug 1912409: Fix flow schema deployment #920
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 | ||
| kind: FlowSchema | ||
| metadata: | ||
| name: openshift-ovn-kubernetes | ||
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
|
There was a problem hiding this comment. This annotation only makes sense for things in There was a problem hiding this comment. ACK, will change. |
||
| spec: | ||
| distinguisherMethod: | ||
| type: ByUser | ||
| matchingPrecedence: 500 | ||
| priorityLevelConfiguration: | ||
| name: system | ||
| rules: | ||
| - nonResourceRules: | ||
| - nonResourceURLs: | ||
| - '*' | ||
| verbs: | ||
| - '*' | ||
| resourceRules: | ||
| - apiGroups: | ||
| - '*' | ||
| clusterScope: true | ||
| namespaces: | ||
| - '*' | ||
| resources: | ||
| - '*' | ||
| verbs: | ||
| - '*' | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| serviceAccount: | ||
| name: ovn-kubernetes-controller | ||
| namespace: openshift-ovn-kubernetes | ||
| - kind: ServiceAccount | ||
| serviceAccount: | ||
| name: ovn-kubernetes-node | ||
| namespace: openshift-ovn-kubernetes | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this must not use v1alpha1. v1alpha1 is subject to going away. Please switch to v1beta1 asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will file a PR momentarily for that. Thanks for letting us now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexanderConstantinescu based on the discussion with @sttts we should leave the version to
v1alpha1for 4.7. We should set the version tov1beta1in 4.8.Please see https://bugzilla.redhat.com/show_bug.cgi?id=1913399#c1