Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1910097: ovn-ipsec: Add resource limits #927

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Bug 1910097: ovn-ipsec: Add resource limits #927

merged 1 commit into from
Jan 5, 2021

Conversation

markdgray
Copy link
Contributor

Fix test case in e2e-ovn-ipsec-step-registry:
"Managed cluster should ensure control plane pods do not run in
best-effort QoS" by requesting cpu and memory resources.

Signed-off-by: Mark Gray mark.d.gray@redhat.com

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@markdgray: This pull request references Bugzilla bug 1910097, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1910097: ovn-ipsec: Add resource limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray markdgray mentioned this pull request Dec 22, 2020
Closed
@markdgray
Copy link
Contributor Author

markdgray commented Dec 23, 2020 •
edited
Loading

/retest

@openshift-ci-robot
Copy link
Contributor

@markdgray: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-ovn 5bca9d8 link /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-windows-custom-vxlan 5bca9d8 link /test e2e-aws-ovn-windows-custom-vxlan
ci/prow/e2e-openstack-ovn 5bca9d8 link /test e2e-openstack-ovn
ci/prow/e2e-gcp 5bca9d8 link /test e2e-gcp
ci/prow/e2e-gcp-ovn 5bca9d8 link /test e2e-gcp-ovn
ci/prow/e2e-ovn-ipsec-step-registry 5bca9d8 link /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn 5bca9d8 link /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-windows 5bca9d8 link /test e2e-aws-ovn-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@markdgray
Copy link
Contributor Author

/retest

1 similar comment
@markdgray
Copy link
Contributor Author

/retest

@markdgray
Copy link
Contributor Author

/test ovn-ipsec-step-registry

@openshift-ci-robot
Copy link
Contributor

@markdgray: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-agnostic-upgrade
  • /test e2e-aws-ovn-windows
  • /test e2e-aws-ovn-windows-custom-vxlan
  • /test e2e-aws-sdn-multi
  • /test e2e-azure-ovn
  • /test e2e-gcp
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-ovn-ipsec-step-registry
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere-ovn
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/test ovn-ipsec-step-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray
ovn-ipsec: Add resource limits
937f3bb 
Fix test case in e2e-ovn-ipsec-step-registry:
"Managed cluster should ensure control plane pods do not run in
best-effort QoS" by requesting cpu and memory resources.

Signed-off-by: Mark Gray <mark.d.gray@redhat.com>
@markdgray markdgray force-pushed the fix/ipsec_resource_limits/1910097 branch from 5bca9d8 to 937f3bb Compare January 5, 2021 10:49
@squeed
Copy link
Contributor

squeed commented Jan 5, 2021

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markdgray, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2021

@markdgray: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-ipsec-step-registry 937f3bb link /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-openstack-ovn 937f3bb link /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-windows 937f3bb link /test e2e-aws-ovn-windows
ci/prow/e2e-aws-ovn-windows-custom-vxlan 937f3bb link /test e2e-aws-ovn-windows-custom-vxlan
ci/prow/e2e-azure-ovn 937f3bb link /test e2e-azure-ovn
ci/prow/e2e-aws-sdn-multi 937f3bb link /test e2e-aws-sdn-multi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8197b2f into openshift:master Jan 5, 2021
@openshift-ci-robot
Copy link
Contributor

@markdgray: All pull requests linked via external trackers have merged:

Bugzilla bug 1910097 has been moved to the MODIFIED state.

In response to this:

Bug 1910097: ovn-ipsec: Add resource limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray markdgray deleted the fix/ipsec_resource_limits/1910097 branch February 9, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu alexanderConstantinescu left review comments

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@squeed squeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markdgray @openshift-ci-robot @squeed @openshift-bot @alexanderConstantinescu @openshift-merge-robot