Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1920159: Reduce CPU requests of ovs daemonset #963

Merged

Conversation

smarterclayton
Copy link
Contributor

Now that OVS has moved to the node in 4.7, the daemonset pods have
less to do. Looking at some production systems data, the OVS pod
uses about 5 millicores on 4.6 and less than 1 millicore on 4.7.
Reduce the request from 100m to 15m to retain some headroom for users
upgrading from 4.6 and running the new pod on the old nodes. In a
future release the daemonset will be fully removed.

/hold

Testing with other PRs

Now that OVS has moved to the node in 4.7, the daemonset pods have
less to do. Looking at some production systems data, the OVS pod
uses about 5 millicores on 4.6 and less than 1 millicore on 4.7.
Reduce the request from 100m to 15m to retain some headroom for users
upgrading from 4.6 and running the new pod on the old nodes. In a
future release the daemonset will be fully removed.
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jan 28, 2021
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: This pull request references Bugzilla bug 1920159, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1920159: Reduce CPU requests of ovs daemonset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2021
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/hold cancel

Combined tests looked ok. Team should review and see the comments in the bug.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2021
@smarterclayton
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit f73b7d2 into openshift:master Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1920159 has not been moved to the MODIFIED state.

In response to this:

Bug 1920159: Reduce CPU requests of ovs daemonset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants