Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing nfd-worker's config #99

Closed
patrykxmatuszak opened this issue Aug 28, 2020 · 11 comments
Closed

Customizing nfd-worker's config #99

patrykxmatuszak opened this issue Aug 28, 2020 · 11 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@patrykxmatuszak
Copy link

Hi,

Is there's any way to customize the nfd-worker's config without building own images?
I wanted to change the labels from vendor to vendor+device id (and possible other), but it seems that after editing configmap -n openshift-nfd nfd-worker operator immediately overwrites with the definition embedded in its container image.

Thanks

@zvonkok
Copy link
Contributor

zvonkok commented Aug 28, 2020

@ArangoGutierrez PTAL

@patrykxmatuszak
Copy link
Author

What is status of the issue? It's rather important for us.

@ArangoGutierrez
Copy link
Contributor

Hi @patrykxmatuszak I am currently working on this on the upstream NFD kubernetes-sigs/node-feature-discovery-operator#36 hope soon will be merged and ported into the OpenShift distribution

@ArangoGutierrez
Copy link
Contributor

@patrykxmatuszak -> kubernetes-sigs/node-feature-discovery-operator#39

once merged upstream, I will try to backport it as soon as I can

@ArangoGutierrez
Copy link
Contributor

Current master now expands the NodeFeatureDiscovery CRD to enable users to modify the CR and define the nfd-worker-conf , or if the operator has already been deployed, users will be able to modify the CR

@ArangoGutierrez
Copy link
Contributor

@patrykxmatuszak please let us know if current master satisfy your use case so we can close this issue :)
thanks for your interest in the project

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 5, 2021
@ArangoGutierrez
Copy link
Contributor

@patrykxmatuszak now you can edit and customize nfd-worker config via CR NodeFeatureDiscovery
Is that ok for you, if so can we close this issue
thanks

@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed May 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants