-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906129: fix manifest files after upstream/downstream sync event #117
Bug 1906129: fix manifest files after upstream/downstream sync event #117
Conversation
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez: This pull request references Bugzilla bug 1906129, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, sjug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ArangoGutierrez: All pull requests linked via external trackers have merged: Bugzilla bug 1906129 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.7 |
@ArangoGutierrez: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.7 and openshift-cherrypick-robot:cherry-pick-117-to-release-4.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Add status checks for TopologyUpdater Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com> Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com> * Enable finalizer check for the CRD Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com> * Apply suggestions from code review Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com> Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com