Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Upstream V0.5.0 #266

Merged
merged 29 commits into from
Jul 7, 2022
Merged

Sync Upstream V0.5.0 #266

merged 29 commits into from
Jul 7, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez commented Jun 28, 2022 •
edited

Cherry-pick

  • 53f9d7df - (origin/devel/pod-security-admision, devel/pod-security-admision) build/assets comply to restricted pod security level (5 weeks ago)
  • 23b9eed2 - (origin/devel/148, devel/148) Update tag on config/manager to v0.4.2 (6 weeks ago)
  • 11180ca8 - Add vscode to gitignore list (6 weeks ago)
  • 18aa20c8 - Bump kube-rbac-proxy to 0.8.0 (6 weeks ago)
  • ed4df102 - Makefile: clean-manifest (6 weeks ago)
  • f7da6cfa - Go mod tidy update run (6 weeks ago)
  • ad98cada - clusterserviceversion: fix nfd cr example (7 weeks ago)
  • c5c18186 - controller: fix nfd-master cmdline args (8 weeks ago)
  • f2ad4b90 - (origin/devel/rbac_hardening, devel/rbac_hardening) Update kubebuilder rbac (9 weeks ago)
  • 539372d0 - Run nfd-master as Deployment (9 weeks ago)
  • c16a6b1d - (origin/devel/controller-gen, devel/controller-gen) Update kubebuilder crd generation (2 months ago)
  • 64859119 - (origin/devel/go_118, devel/go_118) Bump Go to 1.18 (2 months ago)
  • 0f614b0b - (origin/devel/typos, devel/typos) Fix typos (3 months ago)
  • 69848754 - (origin/devel/go-get-tool, devel/go-get-tool) Makefile: use go install to get binaries (3 months ago)
  • a06710a8 - (origin/devel/123, devel/123) Version add a proper way to bake in version into the bin (4 months ago)
  • e761ab01 - Remove non used version folder (4 months ago)
  • e506b76e - (origin/devel/k8s-sigs_nomenclature, devel/k8s-sigs_nomenclature) Align with k8s-sigs nomenclature (4 months ago)
  • 2afae91a - (origin/devel/make_bundle, devel/make_bundle) Enable make bundle (4 months ago)
  • a00547bf - (origin/devel/rbac_04, devel/rbac_04) RBAC add new api's to nfd-master role (4 months ago)
  • 23a3cc96 - (origin/devel/release_list, devel/release_list) Add new check to the release issue template (4 months ago)
  • b4552ce8 - Enable status checks and finalizers for TopologyUpdater (Bug 1906129: fix manifest files after upstream/downstream sync event #117) (4 months ago)
  • 8657ff04 - (origin/devel/v0.4_deps_update) Update dependencies (4 months ago)
  • 5c407b08 - (origin/devel/new_crds, devel/new_crds) Add new CRD's (4 months ago)
  • e533e468 - Edit nfd-topology-updater const for consistency (4 months ago)
  • 809780db - Enable TopologyUpdater worker (4 months ago)
  • e51c5a9e - Enhance GetWatchNamespace func (5 months ago)
  • 7c09709f - Drop operand.namespace from CRD (5 months ago)

ArangoGutierrez and others added 27 commits June 23, 2022 17:17
@ArangoGutierrez
build/assets comply to restricted pod security level
91ea606 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Update tag on config/manager to v0.4.2
7b44016 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Add vscode to gitignore list
2982958 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Bump kube-rbac-proxy to 0.8.0
9ef2513 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Makefile: clean-manifest
8c535b0 
add a function in Makefile to reset config/manager and config/default to
their default values after running a make deploy

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Go mod tidy update run
a189bc8 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@marquiz @ArangoGutierrez
clusterserviceversion: fix nfd cr example
5f6379e 
Remove the invalid namespace field from the embedded
NodeFeatureDiscovery example CR. The namespace field was dropped in
v0.4.0.
@marquiz @ArangoGutierrez
controller: fix nfd-master cmdline args
862874a 
Remove quoting of the arg values which effectively make all of them
broken.
@ArangoGutierrez
Update kubebuilder rbac
b8fb732 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Run nfd-master as Deployment
3d93026 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Update kubebuilder crd generation
460b438 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez @marquiz
Bump Go to 1.18
d3467d5 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez
Fix typos
15df073 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Makefile: use go install to get binaries
1f4a518 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Version add a proper way to bake in version into the bin
6faa79a 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Remove non used version folder
7090eff 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Align with k8s-sigs nomenclature
02bf7c5 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Enable make bundle
7fca637 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
RBAC add new api's to nfd-master role
367cd04 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Add new check to the release issue template
9c7f84c 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez @marquiz
Enable status checks and finalizers for TopologyUpdater (openshift#117)
b941b21 
* Add status checks for TopologyUpdater

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

* Enable finalizer check for the CRD

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* Apply suggestions from code review

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez
Update dependencies
87e3358 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Add new CRD's
ba58c6b 
- NodeFeatureRule
- NodeResourceTopology

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez @marquiz
Edit nfd-topology-updater const for consistency
7446eed 
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez
Enable TopologyUpdater worker
dcb18ac 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez @marquiz
Enhance GetWatchNamespace func
8fa2787 
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez
Drop operand.namespace from CRD
671aeec 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

drop operand.namespace

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Copy link
Contributor Author

/cc @yevgeny-shnaidman @bthurber

@openshift-ci openshift-ci bot requested a review from dagrayvid June 28, 2022 22:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@ArangoGutierrez ArangoGutierrez force-pushed the sync/v05 branch 3 times, most recently from 0baa776 to 640a7ff Compare June 28, 2022 22:59
@ArangoGutierrez
Copy link
Contributor Author

/retest

1 similar comment
@ArangoGutierrez
Copy link
Contributor Author

/retest

bthurber
bthurber reviewed Jun 29, 2022
View reviewed changes
Copy link

@bthurber bthurber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question around where to pull images for downstream for samples.

config/samples/nfd.openshift.io_v1_nodefeaturediscovery.yaml Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Contributor Author

/retest

@ArangoGutierrez
Fix merge conflicts for 4.11
f09d507 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Copy link
Contributor Author

/test e2e-aws

@ArangoGutierrez ArangoGutierrez force-pushed the sync/v05 branch 2 times, most recently from 50102b5 to febb921 Compare July 5, 2022 18:28
@ArangoGutierrez
Fix logs
31ccc5e 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2022

@ArangoGutierrez: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lenahorsley
Copy link

Tested 7 July 2022 (AWS cluster: 3 matser/3 worker nodes)
Build version: 4.11.0-0.nightly-2022-07-06-145812
NFD version (bundle): quay.io/lenahorsley/nfd-operator-bundle:4.11.202207071229
Kube version: v1.24.0+2dd8bb1

  1. Build and deploy NFD bundle. Check the worker node labels.
  2. Add a worker node (g4dn instance) and check new node labels.
  3. Remove the newly added node and check the labels on the remaining nodes.
  4. Log creation and stability.
  5. Check for pods restarts in the openshift-etcd namespace (there were no restarts).

All tests were executed successfully.

@lenahorsley
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@openshift-ci openshift-ci bot merged commit ea7f65b into openshift:master Jul 7, 2022
@montaguethomas montaguethomas mentioned this pull request Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthurber bthurber bthurber left review comments

@yevgeny-shnaidman yevgeny-shnaidman Awaiting requested review from yevgeny-shnaidman

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

Assignees

@lenahorsley lenahorsley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ArangoGutierrez @lenahorsley @bthurber @marquiz