New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: E2E: Delete duplicate mixedcpus e2e test #1015
NO-JIRA: E2E: Delete duplicate mixedcpus e2e test #1015
Conversation
The mixed cpus test added in openshift#967 has been added twice due to probably a rebase issue. This commit removes the duplicated test.
@rbaturov: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, jmencak, rbaturov, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -394,85 +394,6 @@ var _ = Describe("Mixedcpus", Ordered, func() { | |||
mcp, err = mcps.GetByProfile(profile) | |||
Expect(err).ToNot(HaveOccurred()) | |||
|
|||
By("Waiting for mcp to catch up") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the deletion here intentional ? By("Waiting for mcp to catch up")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's likely just a diff artifact. Removing the hunk leads to still correct code with the By
clause and the waits.
@rbaturov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404090113.p0.g2dac3e0.assembly.stream.el9 for distgit cluster-node-tuning-operator. |
The mixed cpus test added in #967 has been added twice due to probably a rebase issue.
This commit removes the duplicated test.