Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: E2E: Delete duplicate mixedcpus e2e test #1015

Merged

Conversation

rbaturov
Copy link
Contributor

@rbaturov rbaturov commented Apr 3, 2024

The mixed cpus test added in #967 has been added twice due to probably a rebase issue.
This commit removes the duplicated test.

The mixed cpus test added in openshift#967 has been added twice due to probably a
rebase issue.
This commit removes the duplicated test.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

@rbaturov: This pull request explicitly references no jira issue.

In response to this:

The mixed cpus test added in #967 has been added twice due to probably a rebase issue.
This commit removes the duplicated test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rbaturov
Copy link
Contributor Author

rbaturov commented Apr 3, 2024

@Tal-or

@openshift-ci openshift-ci bot requested review from ffromani and Tal-or April 3, 2024 10:28
@Tal-or
Copy link
Contributor

Tal-or commented Apr 3, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jmencak
Copy link
Contributor

jmencak commented Apr 8, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, jmencak, rbaturov, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@@ -394,85 +394,6 @@ var _ = Describe("Mixedcpus", Ordered, func() {
mcp, err = mcps.GetByProfile(profile)
Expect(err).ToNot(HaveOccurred())

By("Waiting for mcp to catch up")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the deletion here intentional ? By("Waiting for mcp to catch up")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's likely just a diff artifact. Removing the hunk leads to still correct code with the By clause and the waits.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5cc1952 and 2 for PR HEAD 9712056 in total

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2dac3e0 into openshift:master Apr 8, 2024
16 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404090113.p0.g2dac3e0.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants