Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-11213: added mixedCpus e2e test #967

Merged
merged 2 commits into from Mar 25, 2024
Merged

CNF-11213: added mixedCpus e2e test #967

merged 2 commits into from Mar 25, 2024

Conversation

rbaturov
Copy link
Contributor

Added a test for mixedCpus feature along with some util functions.
This test checks that pods using shared CPUs in a deployment won't
be able to schedule after the mixedCpus feature is disabled and the node reboots.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 22, 2024 •
edited by openshift-ci bot

@rbaturov: This pull request references CNF-11213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Added a test for mixedCpus feature along with some util functions.
This test checks that pods using shared CPUs in a deployment won't
be able to schedule after the mixedCpus feature is disabled and the node reboots.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rbaturov rbaturov changed the title CNF-11213: added mixedCpus unit test CNF-11213: added mixedCpus e2e test Feb 22, 2024
@rbaturov
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
Tal-or
Tal-or suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Tal-or Tal-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, did initial pass

test/e2e/performanceprofile/functests/utils/deployment/deployment.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/utils/deployment/deployment.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/utils/deployment/deployment.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/utils/deployment/deployment.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Show resolved Hide resolved
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Show resolved Hide resolved
@rbaturov rbaturov force-pushed the disable-mixed-cpus-test branch 2 times, most recently from 8e461df to d674963 Compare February 28, 2024 13:01
Tal-or
Tal-or reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Tal-or Tal-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go Outdated Show resolved Hide resolved
@rbaturov rbaturov force-pushed the disable-mixed-cpus-test branch 3 times, most recently from 5d879c0 to 69739e5 Compare February 28, 2024 16:26
@rbaturov
Copy link
Contributor Author

/retest-required

@rbaturov
Copy link
Contributor Author

rbaturov commented Mar 7, 2024

/retest-required

@rbaturov
Copy link
Contributor Author

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@rbaturov
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@rbaturov
Added util functions
2e03990 
Added support to deploy a test deployment
Added a function to check if pod is failed to be scheduled.

Signed-off-by: rbaturov <rbaturov@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@rbaturov
Added mixed cpus test
707aab8 
This test check that pods using shared cpus in a deployment won't
be able to schedule after the mixedCpus feature is disabled and the node reboots.

Signed-off-by: rbaturov <rbaturov@redhat.com>
@rbaturov
Copy link
Contributor Author

/retest-required

4 similar comments
@rbaturov
Copy link
Contributor Author

/retest-required

@rbaturov
Copy link
Contributor Author

/retest-required

@rbaturov
Copy link
Contributor Author

/retest-required

@rbaturov
Copy link
Contributor Author

/retest-required

@Tal-or
Copy link
Contributor

Tal-or commented Mar 21, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yanirq
Copy link
Contributor

yanirq commented Mar 24, 2024

/lgtm

@yanirq
Copy link
Contributor

yanirq commented Mar 24, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rbaturov, Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d46c828 into openshift:master Mar 25, 2024
16 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403242314.p0.gd46c828.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Tal-or pushed a commit to Tal-or/cluster-node-tuning-operator that referenced this pull request Apr 1, 2024
@rbaturov @Tal-or
CNF-11213: added mixedCpus e2e test (openshift#967)
37b658d 
* Added util functions

Added support to deploy a test deployment
Added a function to check if pod is failed to be scheduled.

Signed-off-by: rbaturov <rbaturov@redhat.com>

* Added mixed cpus test

This test check that pods using shared cpus in a deployment won't
be able to schedule after the mixedCpus feature is disabled and the node reboots.

Signed-off-by: rbaturov <rbaturov@redhat.com>

---------

Signed-off-by: rbaturov <rbaturov@redhat.com>
rbaturov added a commit to rbaturov/cluster-node-tuning-operator that referenced this pull request Apr 3, 2024
@rbaturov
Delete duplicate mixedcpus e2e test
4e9c410 
The mixed cpus added in openshift#967 has been added twice due to probably a
rebase issue.
This commit removes the duplicated test.
rbaturov added a commit to rbaturov/cluster-node-tuning-operator that referenced this pull request Apr 3, 2024
@rbaturov
Delete duplicate mixedcpus e2e test
9712056 
The mixed cpus test added in openshift#967 has been added twice due to probably a
rebase issue.
This commit removes the duplicated test.
@rbaturov rbaturov mentioned this pull request Apr 3, 2024
Merged
openshift-merge-bot bot pushed a commit that referenced this pull request Apr 8, 2024
@rbaturov
Delete duplicate mixedcpus e2e test (#1015)
2dac3e0 
The mixed cpus test added in #967 has been added twice due to probably a
rebase issue.
This commit removes the duplicated test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tal-or Tal-or Tal-or requested changes

@ffromani ffromani Awaiting requested review from ffromani

@jmencak jmencak Awaiting requested review from jmencak

Assignees

@yanirq yanirq

@Tal-or Tal-or

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rbaturov @openshift-ci-robot @Tal-or @yanirq @openshift-bot @ffromani @openshift-merge-robot