Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Operator Force/Managed/Removed/Unmanaged management states. #135

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jun 11, 2020

Changes:

  • support for SLO management states
  • made bootcmdline optional in tuned_types.go (it already was optional in openAPIV3Schema)
  • split 02-crd.yaml into two files to prepare the ground for fully automated openAPIV3Schema schema generation

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jun 11, 2020

/uncc @Deepthidharwar
/cc @sjug

@openshift-ci-robot openshift-ci-robot requested review from sjug and removed request for Deepthidharwar June 11, 2020 07:20
@jmencak
Copy link
Contributor Author

jmencak commented Jun 11, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jun 11, 2020

/test e2e-aws-upgrade

Copy link
Contributor

@sjug sjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few thoughts.

pkg/operator/controller.go Show resolved Hide resolved
pkg/operator/controller.go Show resolved Hide resolved
pkg/operator/controller.go Show resolved Hide resolved
pkg/operator/controller.go Outdated Show resolved Hide resolved
Changes:
  - support for SLO management states
  - made bootcmdline optional in tuned_types.go (already
    optional in openAPIV3Schema)
  - split 02-crd.yaml into two files to prepare the ground
    for fully automated openAPIV3Schema schema generation
@sjug
Copy link
Contributor

sjug commented Jul 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sjug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 204a462 into openshift:master Jul 9, 2020
@jmencak jmencak deleted the 4.6-mgmt-state branch July 10, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants