Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile.rhel8 #144

Merged
merged 2 commits into from Jul 22, 2020
Merged

Add Dockerfile.rhel8 #144

merged 2 commits into from Jul 22, 2020

Conversation

yselkowitz
Copy link
Contributor

A separate file is required, as the changes necessary for building with
RHEL 8 content are not compatible with RHEL 7.

jmencak
jmencak reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@jmencak jmencak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for adding this! Tested on x86_64. I'd like to keep the Dockerfiles as close to each other as possible whenever possible. Would you be able to adjust the Dockerfile.rhel7 and Dockerfile based on my comments on line 30? Thank you!

Dockerfile.rhel8 Outdated Show resolved Hide resolved
@yselkowitz
Drop excess dependencies from Dockerfiles
3823539 
All dependencies of tuned will be pulled in when yum installing it.
Only socat is explicitly needed here.
@jmencak
Copy link
Contributor

jmencak commented Jul 22, 2020

/lgtm
/approve
Thank you!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@jmencak jmencak mentioned this pull request Jul 22, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmencak
Copy link
Contributor

jmencak commented Jul 22, 2020

/test e2e-aws

@yselkowitz
Copy link
Contributor Author

/retest

1 similar comment
@yselkowitz
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 920e69b into openshift:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak jmencak left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@sjug sjug Awaiting requested review from sjug

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yselkowitz @jmencak @openshift-ci-robot @openshift-bot @openshift-merge-robot