Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tuned-profiles-nfv profiles, add rtentsk plugin. #146

Merged
merged 1 commit into from Jul 28, 2020
Merged

Enable tuned-profiles-nfv profiles, add rtentsk plugin. #146

merged 1 commit into from Jul 28, 2020

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jul 22, 2020 •
edited

Thanks to the upstream tuned patch it is now possible to ship tuned-profiles-nfv profiles.

This PR adds tuned patches which enable full support of tuned-profiles-nfv. Add [rtentsk] plugin support:
redhat-performance/tuned#289

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@jmencak jmencak mentioned this pull request Jul 22, 2020
Merged
@jmencak
Copy link
Contributor Author

jmencak commented Jul 22, 2020

/hold
Update Dockerfile.rhel8 too once #144 merges.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jul 23, 2020

/hold cancel
@sjug / @dagrayvid PTAL. Needs to merge before code freeze end of next week. Thanks!

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jul 26, 2020

/retest

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Jul 27, 2020

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jul 27, 2020

So the ci/prow/e2e-aws is currently failing but that's not really the PR's fault.
@sjug / @dagrayvid could you please take a look? Feature freeze is end of this week. Thanks.

@jmencak
Enable tuned-profiles-nfv profiles, add rtentsk plugin.
7cc5696 
This PR adds tuned patches which enable full support of
tuned-profiles-nfv.  Add [rtentsk] plugin support:
redhat-performance/tuned#289
@jmencak jmencak changed the title Enable tuned-profiles-nfv profiles. Enable tuned-profiles-nfv profiles, add rtentsk plugin. Jul 28, 2020
@jmencak
Copy link
Contributor Author

jmencak commented Jul 28, 2020

Added the new [rtentsk] plugin to enable full support for tuned-profiles-nfv profiles on RHCOS. Tested that tuned is setting the timestamping socket option on an OCP worker node inside the tuned pod:

sh-4.2#  ps -efL|grep tuned
root     3440244 3439953 3440244  0    3 14:15 ?        00:00:00 /usr/bin/python -Es /usr/sbin/tuned --no-dbus
root     3440244 3439953 3499935  0    3 14:30 ?        00:00:00 /usr/bin/python -Es /usr/sbin/tuned --no-dbus
root     3440244 3439953 3499943  0    3 14:30 ?        00:00:00 /usr/bin/python -Es /usr/sbin/tuned --no-dbus
root     3519598 3441208 3519598  0    1 14:35 pts/0    00:00:00 grep tuned

After creating a profile with [rtentsk] plugin and enabling net_enable_timestamp/net_disable_timestamp tracing:

sh-4.2# grep 3499935 /sys/kernel/debug/tracing/trace
           <...>-3499935 [000] .... 118599.611058: net_enable_timestamp <-sock_setsockopt

and after deleting a profile with [rtentsk] plugin:

sh-4.2# grep 3499935 /sys/kernel/debug/tracing/trace
           <...>-3499935 [000] .... 118599.611058: net_enable_timestamp <-sock_setsockopt
           <...>-3499935 [000] .... 119077.311096: net_disable_timestamp <-__sk_destruct

@dagrayvid
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f8caf60 into openshift:master Jul 28, 2020
@jmencak jmencak deleted the 4.6-realtime-virt-host branch July 29, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@sjug sjug Awaiting requested review from sjug

Assignees

@dagrayvid dagrayvid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmencak @dagrayvid @openshift-ci-robot @openshift-bot @openshift-merge-robot