Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1867604: Set maxUnavailable on ds/tuned to 10% #149

Merged
merged 1 commit into from Aug 10, 2020

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Aug 7, 2020

This daemonset isn't critical for ensuring availability so allow up to
10% to be updated at once

On a 250 node cluster we're seeing about 5 pods per minute
upgrading from 4.5.4 to 4.5.5 which isn't horrible, but we can surely
upgrade more than one at a time.

This daemonset isn't critical for ensuring availability so allow up to
10% to be updated at once
@sdodson
Copy link
Member Author

sdodson commented Aug 7, 2020

@smarterclayton What'd you say was a reasonable maxUnavailable for daemonsets like these?

@jmencak
Copy link
Contributor

jmencak commented Aug 7, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@jmencak
Copy link
Contributor

jmencak commented Aug 7, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7ae70b5 into openshift:master Aug 10, 2020
@sdodson
Copy link
Member Author

sdodson commented Aug 10, 2020

/retitle Bug 1867604: Set maxUnavailable on ds/tuned to 10%

@openshift-ci-robot openshift-ci-robot changed the title Set maxUnavailable on ds/tuned to 10% Bug 1867604: Set maxUnavailable on ds/tuned to 10% Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

@sdodson: All pull requests linked via external trackers have merged: . Bugzilla bug 1867604 has been moved to the MODIFIED state.

In response to this:

Bug 1867604: Set maxUnavailable on ds/tuned to 10%

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants