-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1884287: Upgrade to klog v2. #159
Conversation
@jmencak: An error was encountered adding this pull request to the external tracker bugs for bug 1884287 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kpouget , @dagrayvid this should ideally merge by this Friday, thanks! |
/bugzilla refresh |
@jmencak: This pull request references Bugzilla bug 1884287, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the patch changes klog
from v1.0.0
to v2.3.0
, and most of the changes simply replace import "k8s.io/klog"
by import "k8s.io/klog/v2"
.
Looking at the discussions that happend in this PR:
kubernetes/kubernetes#89717
I checked that:
- all the modules in
vendor
already usev2
- there are use of
if klog.V(x) {
for testing of verbosity level (it seems to beif klog.V(x).Enabled() {
inv2
)
and I can't find anything else that could hide issues, so:
/lgtm
Thanks Jiri for the PR!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, kpouget The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks Kevin, much appreciated! |
@jmencak: All pull requests linked via external trackers have merged: Bugzilla bug 1884287 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.