Updating OWNERS file #184
Updating OWNERS file #184
Conversation
|
/assign @Deepthidharwar |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deepthidharwar, jmencak, zvonkok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Since the recent switch to RHCOS 8.3 (and associated changes with kernel boot parameters after boot), e2e tests will not pass until #183 is merged. Putting on hold until then. |
openshift-ci-robot
added
the
do-not-merge/hold
| @@ -4,7 +4,6 @@ approvers: | |||
| reviewers: | |||
| - ArangoGutierrez | |||
| - cep235 | |||
| - Deepthidharwar | |||
There was a problem hiding this comment.
Would it make sense also to rm from https://github.com/openshift/release/blob/master/ci-operator/config/openshift/cluster-node-tuning-operator/OWNERS#L11 ?
There was a problem hiding this comment.
Thanks for looking Eduardo. It would make sense, but if you read the first two lines in that file, it says the file is autogenerated and that we should not edit it. It is autogenerated presumably from the OWNERS files in this repo. So I believe once this PR merges, that file gets updated too.
|
/uncc @kpouget |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Disscussed this with @Deepthidharwar